-
Notifications
You must be signed in to change notification settings - Fork 21
Make home page responsive and fix element overlap issues #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make home page responsive and fix element overlap issues #136
Conversation
eea6a63 to
6bd3f63
Compare
deneb-alpha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid but the changes on the Latest news section looks broken to me.
the rendering is not good with the text that is still cut off etc
257d689 to
16fa060
Compare
raulillo82
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd prefer to have a second review.
I see something similar to marina, in my case I am using Firefox, but without emulating a mobile device. Should the design be responsive regardless of the device used, just according to the size available? I also see some empty spaces: |
raulillo82
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rachael, please have a look at the comment from Julio. Even if I can see it well in a mobile phone, the fact that we both see weird things when using the dev-tools in the browser, or simply resizing the window, makes me suspicious. Or at least, we'll need to wait till Marina is back and we can have another opinion (she's out this week).
16fa060 to
d952fb7
Compare
deneb-alpha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done! it works now!








Details
This PR addresses the home page responsiveness on smaller screen
Before
After
Fixes #91