Skip to content

Conversation

@Rakielle
Copy link
Contributor

@Rakielle Rakielle commented Sep 3, 2024

Details

This PR addresses the home page responsiveness on smaller screen

Before

img1

After

img2

Fixes #91

@Rakielle Rakielle requested a review from a team September 3, 2024 10:39
@deneb-alpha
Copy link
Contributor

deneb-alpha commented Sep 3, 2024

I was testing the change and something improved, something is still missing...

Current

with your changes:

I tested your PR using the development tools in Firefox.
For the provided screenshots, I selected iPhone11 Pro iOS 14.6 as device. its resolution is 375x812
If this helps, the user agent was: Mozilla/5.0 (iPhone; CPU iPhone OS 14_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Mobile/15E148 Safari/604.1.

But in general, if you switch between the different devices available, you will see similar issues also on other devices.
From what I saw, with your changes, on all the devices I see the top part with the 2 buttons in the right way and the down part with the Latest news still with a broken layout

@Rakielle Rakielle force-pushed the responsive-homepage branch from eea6a63 to 6bd3f63 Compare September 5, 2024 16:36
Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid but the changes on the Latest news section looks broken to me.
the rendering is not good with the text that is still cut off etc

@Rakielle Rakielle force-pushed the responsive-homepage branch 14 times, most recently from 257d689 to 16fa060 Compare September 25, 2024 09:48
@raulillo82 raulillo82 self-requested a review September 25, 2024 11:52
@raulillo82
Copy link
Contributor

I've just tested it locally.
At first, selecting a small device (mobile phone size) with either Firefox or Chrome in developer tools was showing something weird, see this in Firefox:

Captura de pantalla 2024-09-25 a las 14 29 06

and in Chrome:

_home_raul_Documentos_gh-repos_uyuni-project_uyuni-project github io_index html(iPhone SE)

But for Rachael it was fine. So I assumed the problem was my configuration of the developer tools, started a web server from the directory where I cloned Rachael's PR and opened it with my mobile. It is ok there, see:

raul@mordor:~/Documentos/gh-repos/uyuni-project/uyuni-project.github.io (master =)$ export LANG=C
raul@mordor:~/Documentos/gh-repos/uyuni-project/uyuni-project.github.io (master =)$ git checkout rachael/responsive-homepage 
Note: switching to 'rachael/responsive-homepage'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 16fa060 Make home page responsive and fix element overlap issues
raul@mordor:~/Documentos/gh-repos/uyuni-project/uyuni-project.github.io ((16fa060...))$ python3 -m http.server 8080
Serving HTTP on 0.0.0.0 port 8080 (http://0.0.0.0:8080/) ...

And the result looks fine to me:
uyuni-website_xiaomi_14

I'm approving this PR, but would appreciate a second review before merging.

Copy link
Contributor

@raulillo82 raulillo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd prefer to have a second review.

@juliogonzalez
Copy link
Member

juliogonzalez commented Sep 30, 2024

I'm afraid but the changes on the Latest news section looks broken to me. the rendering is not good with the text that is still cut off etc

I see something similar to marina, in my case I am using Firefox, but without emulating a mobile device.

imagen

Should the design be responsive regardless of the device used, just according to the size available?

I also see some empty spaces:

imagen

imagen

Copy link
Contributor

@raulillo82 raulillo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rachael, please have a look at the comment from Julio. Even if I can see it well in a mobile phone, the fact that we both see weird things when using the dev-tools in the browser, or simply resizing the window, makes me suspicious. Or at least, we'll need to wait till Marina is back and we can have another opinion (she's out this week).

@Rakielle Rakielle force-pushed the responsive-homepage branch from 16fa060 to d952fb7 Compare October 20, 2024 17:06
@Rakielle Rakielle requested a review from raulillo82 October 20, 2024 17:06
Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done! it works now!

@deneb-alpha deneb-alpha merged commit 28fb37d into uyuni-project:master Oct 22, 2024
@Rakielle Rakielle deleted the responsive-homepage branch October 22, 2024 17:22
@deneb-alpha deneb-alpha mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Uyuni website responsiveness across different devices

4 participants