Allow passing a Client to get_dataset() #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s if environment variable isn't set or there is no config.
owencjones
approved these changes
Feb 6, 2023
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
This seems like a good DI-style approach that allows both use cases to work (SDK and CLI). Thanks to @hwaxxer for input on this.
balysv
added a commit
that referenced
this pull request
Feb 24, 2023
…mports * master: including release in dataset (#534) [IO-749][external] Added python support install on 3.7 (#540) Io 585 incorrect type annotation (#537) [IO-543][internal] Move Imports To Multiprocessing (#521) Version bump to 0.8.12 HOTFIX: Version for unincluded file (#533) [IO-683][internal] Fix version parsing (#532) [SWAT-753][external]: Fix a 'darwin convert' to mask formats path issue (#531) Added nifti to supported formats. (#530) [IO-665][internal] Type fixes (#529) Allow passing a Client to get_dataset() to avoid authentication errors if environment variable isn't set or there is no config. (#522) Version bump to 0.8.11 Version bump (#528) [SWAT-734][Internal] Fixing conversion to darwin_json_1.0 (#523) Version_bump_v0.8.9 (#527) Updating docs for release process (#525) [io-524][internal] Fix for windows builds [SWAT-716][internal]: Fix .json extension parsing for dataset splitting (#520) [IO-557][internal] Move to use Poetry for packaging and publishing (#512)
balysv
added a commit
that referenced
this pull request
Feb 24, 2023
…mports * master: including release in dataset (#534) [IO-749][external] Added python support install on 3.7 (#540) Io 585 incorrect type annotation (#537) [IO-543][internal] Move Imports To Multiprocessing (#521) Version bump to 0.8.12 HOTFIX: Version for unincluded file (#533) [IO-683][internal] Fix version parsing (#532) [SWAT-753][external]: Fix a 'darwin convert' to mask formats path issue (#531) Added nifti to supported formats. (#530) [IO-665][internal] Type fixes (#529) Allow passing a Client to get_dataset() to avoid authentication errors if environment variable isn't set or there is no config. (#522) Version bump to 0.8.11 Version bump (#528) [SWAT-734][Internal] Fixing conversion to darwin_json_1.0 (#523) Version_bump_v0.8.9 (#527) Updating docs for release process (#525) [io-524][internal] Fix for windows builds [SWAT-716][internal]: Fix .json extension parsing for dataset splitting (#520) [IO-557][internal] Move to use Poetry for packaging and publishing (#512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use this function without setting an environment variable or creating a config file. Currently, calling the function without the environment variable or config file results in an obscure message followed by "Error: Authenticate first"
darwin-py/darwin/cli_functions.py
Line 1242 in 1abb259