-
Notifications
You must be signed in to change notification settings - Fork 47
[SWAT-734][Internal] Fixing conversion to darwin_json_1.0 #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SWAT-734 Dataset conversion failed for FFSS
For FFSS dataset 1: Returns: Total results: fields @timestamp, @message, @logstream, @log For dataset 2, the same issue: This means that busybee failed to convert an annotation. This merits a more profound BB investigation. |
owencjones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| output_file_path: Path = (output_dir / annotation_file.filename).with_suffix(".json") | ||
| with open(output_file_path, "w") as f: | ||
| op = json.dumps(output, option=json.OPT_INDENT_2 | json.OPT_SERIALIZE_NUMPY).decode("utf-8") | ||
| op = json.dumps(output, option=json.OPT_INDENT_2 | json.OPT_SERIALIZE_NUMPY | json.OPT_NON_STR_KEYS).decode( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fl4m3Ph03n1x Do you have example of such annotation that has non string keys? We never use non-string keys, so allowing non string keys feels like a hack, rather then solution. Maybe I'm wrong here, that's why I want to see an example.
I don't want to block this PR if it unblock clients, but I want us to be aware of tech debt that we're creating (cc @owencjones ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @rslota didn't see this: have sent you an example
…mports * master: including release in dataset (#534) [IO-749][external] Added python support install on 3.7 (#540) Io 585 incorrect type annotation (#537) [IO-543][internal] Move Imports To Multiprocessing (#521) Version bump to 0.8.12 HOTFIX: Version for unincluded file (#533) [IO-683][internal] Fix version parsing (#532) [SWAT-753][external]: Fix a 'darwin convert' to mask formats path issue (#531) Added nifti to supported formats. (#530) [IO-665][internal] Type fixes (#529) Allow passing a Client to get_dataset() to avoid authentication errors if environment variable isn't set or there is no config. (#522) Version bump to 0.8.11 Version bump (#528) [SWAT-734][Internal] Fixing conversion to darwin_json_1.0 (#523) Version_bump_v0.8.9 (#527) Updating docs for release process (#525) [io-524][internal] Fix for windows builds [SWAT-716][internal]: Fix .json extension parsing for dataset splitting (#520) [IO-557][internal] Move to use Poetry for packaging and publishing (#512)
…mports * master: including release in dataset (#534) [IO-749][external] Added python support install on 3.7 (#540) Io 585 incorrect type annotation (#537) [IO-543][internal] Move Imports To Multiprocessing (#521) Version bump to 0.8.12 HOTFIX: Version for unincluded file (#533) [IO-683][internal] Fix version parsing (#532) [SWAT-753][external]: Fix a 'darwin convert' to mask formats path issue (#531) Added nifti to supported formats. (#530) [IO-665][internal] Type fixes (#529) Allow passing a Client to get_dataset() to avoid authentication errors if environment variable isn't set or there is no config. (#522) Version bump to 0.8.11 Version bump (#528) [SWAT-734][Internal] Fixing conversion to darwin_json_1.0 (#523) Version_bump_v0.8.9 (#527) Updating docs for release process (#525) [io-524][internal] Fix for windows builds [SWAT-716][internal]: Fix .json extension parsing for dataset splitting (#520) [IO-557][internal] Move to use Poetry for packaging and publishing (#512)
Conversions from darwin_2.0 to darwin_1.0 are broken right now.
This PR aims to fix that with a temporary quick fix that reverts the json encoder used.
Ticket: https://linear.app/v7labs/issue/SWAT-734/dataset-conversion-failed-for-ffss
Context: https://vseven.slack.com/archives/C03LKKX7D0U/p1675160311013969