Skip snapshot tests when snapshots are disabled#246
Merged
victorgomes merged 1 commit intov8:node-ci-2026-02-24from Mar 24, 2026
Merged
Skip snapshot tests when snapshots are disabled#246victorgomes merged 1 commit intov8:node-ci-2026-02-24from
victorgomes merged 1 commit intov8:node-ci-2026-02-24from
Conversation
These tests create node snapshots even when node snapshots are disabled. Node snapshots don't work at the moment because FunctionTemplateInfo objects with fast API callbacks are put into the snapshot. However, the way FunctionTemplateInfo objects reference fast API callbacks at the moment causes security issues, and the fix references fast API callbacks via a dynamically allocated C++ object, which cannot be put into the snapshot.
gahaas
force-pushed
the
2026-03-24_fix_name
branch
from
39e5f28 to
42e64bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests create node snapshots even when node snapshots are disabled. Node snapshots don't work at the moment because FunctionTemplateInfo objects with fast API callbacks are put into the snapshot, but this causes security issues.