feat: add MarkdownTester for Markdown components - #132
Conversation
Adds a MarkdownTester wrapping com.vaadin.flow.component.markdown.Markdown so the annotation processor generates a MarkdownLocator and the findMarkdown()/use(Markdown) entries on GeneratedLocators. Also registers the tester in TesterWrappers for the test(Markdown) DSL. Fixes #131
| * @param <T> | ||
| * component type | ||
| */ | ||
| @Tests(Markdown.class) |
There was a problem hiding this comment.
do we need a @since tag, or will we delegate this to the new workflow?
There was a problem hiding this comment.
Good catch — added @since 1.1 to the class Javadoc, matching the convention used by the other recently added testers (e.g. DashboardTester and the slider testers) at the current 1.1-SNAPSHOT version.
There was a problem hiding this comment.
Reversed course here: rather than adding a @since tag, added a contributing guideline (CONTRIBUTING.md) stating that individual PRs should not add @since tags — these are added in a separate pass before a release so the version is correct. Dropped the @since 1.1 tag from MarkdownTester accordingly.
There was a problem hiding this comment.
Can you make exactly two commits (tester and CONTRIBUTING.md), so we can merge them separately? Or make a distinct PR for contributing guidelines.
There was a problem hiding this comment.
Split the two concerns apart. This PR is now scoped to the MarkdownTester only — I removed CONTRIBUTING.md here — and the @since guideline moved to its own PR (#133) so the two can be reviewed and merged independently. The tester carries no @since tag, in line with that guideline.
Add @SInCE tags separately before a release to ensure they are correct, and drop the tag added to MarkdownTester.
Keep this PR focused on the MarkdownTester; the contributing guideline about @SInCE tags will be proposed in a separate PR so it can be reviewed and merged independently.
Adds a `CONTRIBUTING.md` documenting that individual PRs should not add `@since` tags. These are added in a separate pass before a release, once the target version is known, to ensure they are correct. Split out from #132 so the tester and the guideline can be reviewed and merged independently. Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
1 participant
Adds a
MarkdownTesterwrappingcom.vaadin.flow.component.markdown.Markdownso the annotation processor generates aMarkdownLocatoralong with thefindMarkdown()/use(Markdown)entries onGeneratedLocators. The tester is also registered inTesterWrappersto enable thetest(Markdown)DSL.Includes a
MarkdownTesterTestand aMarkdownViewcovering the new tester.Fixes #131
Notes
@sincetags; those are added separately before a release to ensure they are correct) will be submitted as a separate PR so it can be reviewed and merged independently. The@sincetag briefly added toMarkdownTesterhas been dropped accordingly.