fix: throw error if requested page or item count exceeds the Flow limit by ugur-vaadin · Pull Request #3798 · vaadin/flow-components

ugur-vaadin · 2022-09-29T04:51:32Z

Description

A recent change in Flow has limited the number of pages in the response to 10. Also, there is an issue to add another constraint to the responses to have a maximum item count of 500. This PR ensures that these constraints are respected in the Grid. If more pages or items are requested from the, an exception will be thrown.

Should be merged after the Flow issue is merged.

Fixes #3708

Type of change

Bugfix
Feature

Checklist

I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
I have added a description following the guideline.
The issue is created in the corresponding repository and I have referenced it.
I have added tests to ensure my change is effective and works as intended.
New and existing tests are passing locally with my change.
I have performed self-review and corrected misspellings.

… the connector Correct length check, add isAllRowsVisible check, carry the code to the server side.

sonarqubecloud · 2022-10-04T04:21:17Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
41 Code Smells

No Coverage information
0.0% Duplication

tomivirkki

LGTM

Should be merged after the Flow vaadin/flow#14630 is merged.

I think this change would already provide value for users, even before the DataProvider issue in Flow is fixed.

vursen · 2022-10-05T06:08:19Z

+                | IllegalAccessException | IllegalArgumentException
+                | InvocationTargetException e) {
+            if (e.getCause() instanceof IllegalArgumentException) {
+                throw (IllegalArgumentException) e.getCause();


Did I read it correctly that this just re-throws IllegalArgumentException? Could it be then excluded from the union of exceptions above?

vursen · 2022-10-05T09:33:01Z

+            if (e.getCause() instanceof IllegalArgumentException) {
+                throw (IllegalArgumentException) e.getCause();
+            }
+            Assert.fail("Could not call Grid.setRequestedRange");


I guess it would be helpful to know the cause of the failure here. Could we simply not handle these exceptions like here? Does that approach have any negative consequences?

…ter-10-x-pagesize-items

sonarqubecloud · 2022-11-22T13:37:17Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
45 Code Smells

No Coverage information
0.0% Duplication

…it (#3798) * fix: throw error if requested page or item count exceeds the Flow limit * fix: correct the if clause and check it in the server side instead of the connector Correct length check, add isAllRowsVisible check, carry the code to the server side. * fix: change the exception message * test: add tests for request variations

…it (#3798) (#4171) * fix: throw error if requested page or item count exceeds the Flow limit * fix: correct the if clause and check it in the server side instead of the connector Correct length check, add isAllRowsVisible check, carry the code to the server side. * fix: change the exception message * test: add tests for request variations Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>

…it (#3798) (#4172) * fix: throw error if requested page or item count exceeds the Flow limit * fix: correct the if clause and check it in the server side instead of the connector Correct length check, add isAllRowsVisible check, carry the code to the server side. * fix: change the exception message * test: add tests for request variations Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>

…it (#3798) (#4173) * fix: throw error if requested page or item count exceeds the Flow limit * fix: correct the if clause and check it in the server side instead of the connector Correct length check, add isAllRowsVisible check, carry the code to the server side. * fix: change the exception message * test: add tests for request variations Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>

…it (#3798) (#4174) * fix: throw error if requested page or item count exceeds the Flow limit * fix: correct the if clause and check it in the server side instead of the connector Correct length check, add isAllRowsVisible check, carry the code to the server side. * fix: change the exception message * test: add tests for request variations Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>

vaadin-bot · 2022-11-25T15:48:40Z

This ticket/PR has been released with Vaadin 24.0.0.alpha5 and is also targeting the upcoming stable 24.0.0 version.
This ticket/PR has been released with Vaadin 23.2.9
This ticket/PR has been released with Vaadin 23.1.16

fix: throw error if requested page or item count exceeds the Flow limit

e0ded4a

ugur-vaadin requested a review from tomivirkki September 29, 2022 04:51

ugur-vaadin linked an issue Sep 29, 2022 that may be closed by this pull request

Grid and TreeGrid: Empty item lines after 10 x pageSize items. #3708

Closed

tomivirkki requested changes Sep 29, 2022

View reviewed changes

fix: correct the if clause and check it in the server side instead of…

74d6966

… the connector Correct length check, add isAllRowsVisible check, carry the code to the server side.

tomivirkki reviewed Sep 29, 2022

View reviewed changes

Comment thread vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java

Comment thread vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java Outdated

ugur-vaadin added 2 commits October 4, 2022 07:11

fix: change the exception message

594ef6f

test: add tests for request variations

b522912

tomivirkki approved these changes Oct 4, 2022

View reviewed changes

vursen reviewed Oct 5, 2022

View reviewed changes

ugur-vaadin added 2 commits November 22, 2022 09:56

Merge branch 'master' into 3708-grid-and-treegrid-empty-item-lines-af…

383363e

…ter-10-x-pagesize-items

Merge branch 'master' into 3708-grid-and-treegrid-empty-item-lines-af…

2b00cd5

…ter-10-x-pagesize-items

ugur-vaadin merged commit e54b056 into master Nov 22, 2022

ugur-vaadin deleted the 3708-grid-and-treegrid-empty-item-lines-after-10-x-pagesize-items branch November 22, 2022 13:44

ZheSun88 added target/22.0 labels Nov 22, 2022

vaadin-bot added the cherry-picked-23.3 label Nov 22, 2022

vaadin-bot added the cherry-picked-23.2 label Nov 22, 2022

vaadin-bot added the cherry-picked-23.1 label Nov 22, 2022

vaadin-bot added the cherry-picked-22.0 label Nov 22, 2022

vaadin-bot added the prerelease version for Vaadin 24.0.0 label Nov 25, 2022

vaadin-bot added the Released with Vaadin 24.0.0.alpha5 label Nov 25, 2022

ZheSun88 added Released with Vaadin 23.1.16 Released with Vaadin 23.2.9 labels Nov 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: throw error if requested page or item count exceeds the Flow limit#3798

fix: throw error if requested page or item count exceeds the Flow limit#3798
ugur-vaadin merged 6 commits intomasterfrom
3708-grid-and-treegrid-empty-item-lines-after-10-x-pagesize-items

ugur-vaadin commented Sep 29, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Oct 4, 2022

Uh oh!

tomivirkki left a comment

Uh oh!

vursen Oct 5, 2022

Uh oh!

vursen Oct 5, 2022 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Nov 22, 2022

Uh oh!

vaadin-bot commented Nov 25, 2022 •

edited by ZheSun88

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ugur-vaadin commented Sep 29, 2022

Description

Type of change

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Oct 4, 2022

Uh oh!

tomivirkki left a comment

Choose a reason for hiding this comment

Uh oh!

vursen Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

vursen Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Nov 22, 2022

Uh oh!

vaadin-bot commented Nov 25, 2022 • edited by ZheSun88 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vursen Oct 5, 2022 •

edited

Loading

vaadin-bot commented Nov 25, 2022 •

edited by ZheSun88

Loading