fix: Limit the requested pages to a given threshold by mshabarov · Pull Request #12003 · vaadin/flow

mshabarov · 2021-10-08T08:05:42Z

Description

Limits the number of requested items from backend to a given threshold of ten pages.

Depends on vaadin/web-components#2801 and web-components new release.

Type of change

Bugfix
Feature

Checklist

I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
I have added a description following the guideline.
The issue is created in the corresponding repository and I have referenced it.
I have added tests to ensure my change is effective and works as intended.
New and existing tests are passing locally with my change.
I have performed self-review and corrected misspellings.

Additional for `Feature` type of change

Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Limits the number of requested items from backend to a given threshold of ten pages.

pleku · 2021-10-26T06:27:59Z

    public static final int DEFAULT_PAGE_INCREASE_COUNT = 4;

    private static final int DEFAULT_PAGE_SIZE = 50;
+    private static final int MAXIMUM_ALLOWED_ITEMS_FACTOR = 10;


Factor ? I would simply call it pages e.g. maximum allowed pages since it seems to correspond to that, so why not just name it for that ?

Agree, it's better no name it maximum allowed pages.

pleku · 2021-10-26T06:30:51Z

    public void setRequestedRange(int start, int length) {
+        final int maximumAllowedItems = getMaximumAllowedItems();
+        if (length > maximumAllowedItems) {
+            throw new IllegalStateException(String.format(


Why throwing and breaking the UI ? What happens if the length is limited to maximum allowed ?

IIRC, the grid will simply request again if it needs more (?).
And the server side will anyway keep fetching for more until less are returned than what was requested, or until the size has been reached.

Yes, you're right. Better to cut/limit the requested items, than to throw. So I'll just warn about too many items requested and cut the length to acceptable.

I think that was a wrong decision. Otherwise we would likely have seen bug much much earlier.

vaadin-bot · 2021-10-26T08:28:31Z

SonarQube analysis reported 3 issues

DataCommunicator.java#L325: Invoke method(s) only conditionally.
DataCommunicator.java#L1086: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.
DataCommunicator.java#L495: Complete the task associated to this TODO comment.

Limits the number of requested items from backend to a given threshold of ten pages.

vaadin-bot · 2021-11-01T12:13:12Z

Hi @mshabarov and @pleku, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 0ec90bf
error: could not apply 0ec90bf... fix: Limit the requested pages to a given threshold (#12003)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

vaadin-bot · 2021-11-01T12:13:17Z

Hi @mshabarov and @pleku, when i performed cherry-pick to this commit to 1.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 0ec90bf
error: could not apply 0ec90bf... fix: Limit the requested pages to a given threshold (#12003)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

Limits the number of requested items from backend to a given threshold of ten pages. Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>

Limits the number of requested items from backend to a given threshold of ten pages. (cherry picked from commit 0ec90bf)

…#12238) Limits the number of requested items from backend to a given threshold of ten pages. (cherry picked from commit 0ec90bf)

…#12238) (#12275) Limits the number of requested items from backend to a given threshold of ten pages. (cherry picked from commit 0ec90bf)

Limits the number of requested items from backend to a given threshold of ten pages. Exactly the same as #12003, but applied to HierarchicalDataCommunicator. Fixes #18403

Limits the number of requested items from backend to a given threshold of ten pages. Exactly the same as #12003, but applied to HierarchicalDataCommunicator. Fixes #18403 Co-authored-by: Marco Collovati <marco@vaadin.com>

Limits the number of requested items from backend to a given threshold of ten pages. Exactly the same as #12003, but applied to HierarchicalDataCommunicator. Fixes #18403

mshabarov added 2 commits October 8, 2021 10:59

fix: Limit the requested pages to a given threshold

871cd46

Limits the number of requested items from backend to a given threshold of ten pages.

fix formatting

16fc6ea

vaadin-bot added the +0.0.1 label Oct 8, 2021

mshabarov added 3 commits October 11, 2021 09:37

Merge remote-tracking branch 'origin/master' into fix/fetch-items-limit

7be8c18

Merge remote-tracking branch 'origin/master' into fix/fetch-items-limit

803aebd

Merge remote-tracking branch 'origin/master' into fix/fetch-items-limit

b176715

mshabarov added target/1.0 target/2.7 labels Oct 20, 2021

pleku suggested changes Oct 26, 2021

View reviewed changes

fix: Not throw but log and cut the items count requested

917f216

mshabarov requested a review from pleku October 27, 2021 10:14

pleku approved these changes Oct 27, 2021

View reviewed changes

mshabarov marked this pull request as ready for review November 1, 2021 12:10

pleku merged commit 0ec90bf into master Nov 1, 2021

pleku deleted the fix/fetch-items-limit branch November 1, 2021 12:11

vaadin-bot pushed a commit that referenced this pull request Nov 1, 2021

fix: Limit the requested pages to a given threshold (#12003)

e5def43

Limits the number of requested items from backend to a given threshold of ten pages.

vaadin-bot added the cherry-picked-8.0 label Nov 1, 2021

vaadin-bot added need to pick manually 2.7 need to pick manually 1.0 labels Nov 1, 2021

mshabarov added a commit that referenced this pull request Nov 2, 2021

fix: Limit the requested pages to a given threshold (#12003)

3375258

Limits the number of requested items from backend to a given threshold of ten pages. (cherry picked from commit 0ec90bf)

mshabarov added a commit that referenced this pull request Nov 2, 2021

fix: Limit the requested pages to a given threshold (#12003)

92e229b

Limits the number of requested items from backend to a given threshold of ten pages. (cherry picked from commit 0ec90bf)

pleku pushed a commit that referenced this pull request Nov 4, 2021

fix: Limit the requested pages to a given threshold (#12003)(CP: 2.7) (…

5e8dd34

…#12238) Limits the number of requested items from backend to a given threshold of ten pages. (cherry picked from commit 0ec90bf)

vaadin-bot mentioned this pull request Nov 4, 2021

fix: Limit the requested pages to a given threshold (#12003)(CP: 2.7) #12238

Merged

9 tasks

mshabarov added a commit that referenced this pull request Nov 4, 2021

fix: Limit the requested pages to a given threshold (#12003)(CP: 2.7) (…

2a50902

…#12238) Limits the number of requested items from backend to a given threshold of ten pages. (cherry picked from commit 0ec90bf)

pleku pushed a commit that referenced this pull request Nov 4, 2021

fix: Limit the requested pages to a given threshold (#12003)(CP: 2.7) (…

139b4fd

…#12238) (#12275) Limits the number of requested items from backend to a given threshold of ten pages. (cherry picked from commit 0ec90bf)

enver-haase mentioned this pull request Sep 15, 2022

Grid and TreeGrid: Empty item lines after 10 x pageSize items. vaadin/flow-components#3708

Closed

ugur-vaadin mentioned this pull request Sep 29, 2022

fix: throw error if requested page or item count exceeds the Flow limit vaadin/flow-components#3798

Merged

8 tasks

vursen mentioned this pull request Jan 8, 2024

Should have a limit on the number of sub-level items that can be requested #18403

Closed

mcollovati mentioned this pull request Jan 9, 2024

fix: limit the requested items to a given threshold #18417

Merged

9 tasks

mcollovati mentioned this pull request Jan 10, 2024

fix: limit the requested items to a given threshold (#18417) #18425

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Limit the requested pages to a given threshold#12003

fix: Limit the requested pages to a given threshold#12003
pleku merged 6 commits intomasterfrom
fix/fetch-items-limit

mshabarov commented Oct 8, 2021 •

edited

Loading

Uh oh!

pleku Oct 26, 2021

Uh oh!

mshabarov Oct 26, 2021

Uh oh!

mshabarov Oct 26, 2021

Uh oh!

pleku Oct 26, 2021

Uh oh!

mshabarov Oct 26, 2021

Uh oh!

mshabarov Oct 26, 2021

Uh oh!

enver-haase Sep 15, 2022

Uh oh!

vaadin-bot commented Oct 26, 2021

Uh oh!

vaadin-bot commented Nov 1, 2021

Uh oh!

vaadin-bot commented Nov 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mshabarov commented Oct 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist

Additional for Feature type of change

Uh oh!

pleku Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

mshabarov Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

mshabarov Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

pleku Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

mshabarov Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

mshabarov Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

enver-haase Sep 15, 2022

Choose a reason for hiding this comment

Uh oh!

vaadin-bot commented Oct 26, 2021

Uh oh!

vaadin-bot commented Nov 1, 2021

Uh oh!

vaadin-bot commented Nov 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mshabarov commented Oct 8, 2021 •

edited

Loading

Additional for `Feature` type of change