fix: keep scroll position when setting item selectable provider - #9644
Merged
Conversation
setItemSelectableProvider called getDataCommunicator().reset(), which resets the scroll position to the top. Use refreshViewport() instead, like other Grid setters that only need to re-render visible rows. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
vursen
changed the title
vursen
changed the title
vursen
changed the title
vursen
changed the title
vursen
changed the title
vursen
changed the title
vursen
changed the title
web-padawan
approved these changes
Jul 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Jul 1, 2026
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Resolved. Both |
vursen
enabled auto-merge
July 1, 2026 09:42
|
vursen
added a commit
that referenced
this pull request
Jul 1, 2026
… (#9655) This PR cherry-picks changes from the original PR #9644 to branch 25.1. --- #### Original PR description > This PR changes `setItemSelectableProvider` to use `refreshViewport()` instead of `dataCommunicator.reset()` to avoid resetting TreeGrid's scroll position and adds a corresponding test to `TreeGridScrollPositionIT`. Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
vursen
added a commit
that referenced
this pull request
Jul 1, 2026
… (#9654) This PR cherry-picks changes from the original PR #9644 to branch 25.2. --- #### Original PR description > This PR changes `setItemSelectableProvider` to use `refreshViewport()` instead of `dataCommunicator.reset()` to avoid resetting TreeGrid's scroll position and adds a corresponding test to `TreeGridScrollPositionIT`. Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
setItemSelectableProviderto userefreshViewport()instead ofdataCommunicator.reset()to avoid resetting TreeGrid's scroll position and adds a corresponding test toTreeGridScrollPositionIT.