fix: include descendant items in TreeGrid selectAll (#9819) (CP: 25.2) - #9830
Merged
Conversation
Calling `selectAll()` on GridMultiSelectionModel used to fetch items with a non-hierarchical query. With a hierarchical data provider, this resulted in an IllegalArgumentException in Vaadin 23 and 24. Since Vaadin 25, `HierarchicalDataCommunicator.buildQuery` returns a root-level hierarchical query, so the exception is gone, but `selectAll()` still selects only root items. The `clientSelectAll` method already handles hierarchical data providers by fetching all descendants recursively. This change extracts that logic into a shared method and makes `selectAll()` use it too, so both behave the same. Fixes #9816 Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
|
vursen
enabled auto-merge (squash)
August 6, 2026 07:37
vursen
approved these changes
Aug 6, 2026
Collaborator
Author
|
This ticket/PR has been released with Vaadin 25.2.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #9819 to branch 25.2.
Original PR description