fix: use getContentLengthLong instead getContentLength (#10506) (CP: 2.5)#10540
Merged
Conversation
Use Servlet 3.1 ServletRequest::getContentLengthLong to get the content size as a long value for the big files upload, because getContentLength may return -1 (file size is bigger than int capacity). fixes #10392
vaadin-bot
commented
Apr 1, 2021
| StateNode owner) throws IOException { | ||
| boolean success = true; | ||
| long contentLength = request.getContentLength(); | ||
| long contentLength = getContentLength(request); |
Collaborator
Author
There was a problem hiding this comment.
vaadin-bot
commented
Apr 1, 2021
| * @deprecated use {@link VaadinRequest#getContentLengthLong()} instead | ||
| */ | ||
| @Deprecated | ||
| protected long getContentLength(VaadinRequest request) { |
Collaborator
Author
There was a problem hiding this comment.
Collaborator
Author
|
SonarQube analysis reported 3 issues
Watch the comments in this conversation to review them. 1 extra issueNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
pleku
approved these changes
Apr 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.