Skip to content

fix: Added support for custom frontendDirectory in TaskCopyTemplateFiles (#14527) (CP 9.0)#14559

Merged
MarcinVaadin merged 1 commit into
9.0from
14527-manual-merge-to-9.0
Sep 19, 2022
Merged

fix: Added support for custom frontendDirectory in TaskCopyTemplateFiles (#14527) (CP 9.0)#14559
MarcinVaadin merged 1 commit into
9.0from
14527-manual-merge-to-9.0

Conversation

@MarcinVaadin

Copy link
Copy Markdown
Contributor

Description

Added support for custom frontendDirectory in TaskCopyTemplateFiles (#14527) (CP 9.0)

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes #14527

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions

Copy link
Copy Markdown

Unit Test Results

   776 files  +2     776 suites  +2   25m 13s ⏱️ -54s
5 765 tests ±0  5 714 ✔️ +1  51 💤  - 1  0 ±0 
5 816 runs  +6  5 764 ✔️ +7  52 💤  - 1  0 ±0 

Results for commit 8d9ae74. ± Comparison against base commit 73ab866.

@MarcinVaadin MarcinVaadin enabled auto-merge (squash) September 19, 2022 07:42
const versionsFile = require('path').resolve(__dirname, 'target/frontend/versions.json');

if (!fs.existsSync(versionsFile)) {
return;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSC_PARSE_ERROR: Parse error. return must be inside function


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonatype-lift ignore

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.

@MarcinVaadin MarcinVaadin merged commit 24371cb into 9.0 Sep 19, 2022
@MarcinVaadin MarcinVaadin deleted the 14527-manual-merge-to-9.0 branch September 19, 2022 07:45
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 22.0.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants