fix: sort classes by name in ReflectionsClassFinder (#14556) (CP: 23.2)#14622
Merged
Conversation
Class scan in production build may differ from development mode because DefaultClassFinder and ReflectionsClassFinder may provide classes in different order. As a result, when there are multiple NpmPackage annotations for the same package wit different version, the final version used in package.json may be different in dev mode and production build. This change makes ReflectionsClassFinder sort classes by name, as DefaultClassFinder does in its constructor. Ref #14381
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-review-bot
approved these changes
Sep 23, 2022
mcollovati
approved these changes
Sep 23, 2022
Collaborator
Author
|
This ticket/PR has been released with Vaadin 23.2.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.