Skip to content

fix: Fix navigation to secured view with oauth2 without router-ignore (#14523) (CP: 23.2)#14653

Merged
mcollovati merged 1 commit into
23.2from
cherry-pick-14523-to-23.2-1664268552892
Sep 27, 2022
Merged

fix: Fix navigation to secured view with oauth2 without router-ignore (#14523) (CP: 23.2)#14653
mcollovati merged 1 commit into
23.2from
cherry-pick-14523-to-23.2-1664268552892

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

…#14523)

This is to fix the problem of navigating to a secured view
from a public view before login in while using the OAuth2 external
login page. Prior to this, it was needed to set "router-ignore"
attribute on the links from public pages to skip vaadin-router and
let the spring-security forward the user to the external login page.

Fixes #14253
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati mcollovati enabled auto-merge (squash) September 27, 2022 08:57
@github-actions

Copy link
Copy Markdown

Unit Test Results

   923 files  ±0     923 suites  ±0   49m 21s ⏱️ -29s
6 042 tests +6  5 989 ✔️ +5  53 💤 +1  0 ±0 
6 262 runs  +1  6 202 ✔️ ±0  60 💤 +1  0 ±0 

Results for commit 9e4a882. ± Comparison against base commit 673baa7.

@mcollovati mcollovati merged commit b598b50 into 23.2 Sep 27, 2022
@mcollovati mcollovati deleted the cherry-pick-14523-to-23.2-1664268552892 branch September 27, 2022 09:06
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 23.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants