Skip to content

fix: Do not use a fixed download root (#14632) (CP: 23.2)#14690

Merged
mcollovati merged 1 commit into
23.2from
cherry-pick-14632-to-23.2-1664445586167
Sep 29, 2022
Merged

fix: Do not use a fixed download root (#14632) (CP: 23.2)#14690
mcollovati merged 1 commit into
23.2from
cherry-pick-14632-to-23.2-1664445586167

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

* fix: Do not use a fixed download root

As the default download root might be
different depending on the used system
we should not use a hardcoded default if
user has not given a download root.

Fixes #13837

* fix static mock
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

Copy link
Copy Markdown

Unit Test Results

   929 files  ±  0     929 suites  ±0   52m 52s ⏱️ + 4m 13s
6 050 tests ±  0  5 997 ✔️ ±  0  53 💤 ±0  0 ±0 
6 282 runs  +12  6 222 ✔️ +12  60 💤 ±0  0 ±0 

Results for commit bd23685. ± Comparison against base commit 4414f58.

@mcollovati mcollovati merged commit 9dddc60 into 23.2 Sep 29, 2022
@mcollovati mcollovati deleted the cherry-pick-14632-to-23.2-1664445586167 branch September 29, 2022 10:41
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 23.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants