fix: Skip checking @vaadin/flow-frontend package (CP: 24.0)#16140
Conversation
@vaadin/flow-frontend package was used in previous Vaadin versions to alias .target/flow-frontend folder. Since it is present only under "dependencies" object, Flow cannot decide was it added by user or not. Now Flow ignores this legacy package to not re-bundle erroneously.
mshabarov
changed the title
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| List<String> dependenciesList = Arrays.stream(dependencies.keys()) | ||
| // skip checking flow-frontend as it was used in previous | ||
| // versions as an alias for ./target/flow-frontend | ||
| .filter(pkg -> !"@vaadin/flow-frontend".equals(pkg)) |
There was a problem hiding this comment.
YodaCondition: The non-constant portion of an equals check generally comes first.
| .filter(pkg -> !"@vaadin/flow-frontend".equals(pkg)) | |
| .filter(pkg -> !Objects.equals(pkg, "@vaadin/flow-frontend")) |
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/vaadin/flow/16140.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/vaadin/flow/16140.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
|
Kudos, SonarCloud Quality Gate passed!
|
5 participants
@vaadin/flow-frontend package was used in previous Vaadin versions to alias .target/flow-frontend folder. Since it is present only under "dependencies" object, Flow cannot decide was it added by user or not. Now Flow ignores this legacy package to not re-bundle erroneously.