Skip to content

fix: Fall back to InternalServerError when error view rendering fails (#23177) (CP: 25.0) #23247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcollovati merged 2 commits into from
Jan 21, 2026
Merged

fix: Fall back to InternalServerError when error view rendering fails (#23177) (CP: 25.0) #23247

mcollovati merged 2 commits into from
Jan 21, 2026

Conversation

@vaadin-bot
Copy link
Collaborator

@vaadin-bot vaadin-bot commented Jan 19, 2026

This PR cherry-picks changes from the original PR #23177 to branch 25.0.

Original PR description

Prevents navigation corruption when error view's parent layout throws an exception during afterNavigation by catching the exception and rendering InternalServerError as fallback.

Fixes #22146

@Artur- @vaadin-bot
fix: Fall back to InternalServerError when error view rendering fails (…
30405ad 
…#23177)

Prevents navigation corruption when error view's parent layout throws
an exception during afterNavigation by catching the exception and
rendering InternalServerError as fallback.

Fixes #22146
@github-actions
Copy link

github-actions bot commented Jan 20, 2026 •
edited
Loading

Test Results

1 310 files  1 310 suites   1h 17m 3s ⏱️
9 282 tests 9 214 ✅ 68 💤 0 ❌
9 742 runs  9 666 ✅ 76 💤 0 ❌

Results for commit a72e0d6.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 20, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mcollovati mcollovati merged commit ab2317f into 25.0 Jan 21, 2026
30 checks passed
@mcollovati mcollovati deleted the cherry-pick-23177-to-25.0-1768825188359 branch January 21, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees

No one assigned

Labels

+0.0.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vaadin-bot @mcollovati @Artur- @caalador