feat: Add HasPlaceholder::bindPlaceholder(Signal<String>) #23253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 🔎Iteration reviews
in Vaadin Flow | Hilla | Kits ongoing work
tltv
reviewed
Jan 20, 2026
flow-server/src/test/java/com/vaadin/flow/component/HasPlaceholderBindTest.java
Show resolved
Hide resolved
tltv
previously approved these changes
Jan 21, 2026
| assertEquals("foo", component.getPlaceholder()); | ||
|
|
||
| try { | ||
| component.setPlaceholder("bar"); |
Member
There was a problem hiding this comment.
nit: assertThrows(BindingActiveException.class, () -> component.setPlaceholder("bar")) would be in general a bit tidier, but this does also the job.
Contributor
Author
There was a problem hiding this comment.
good comment, replaced.
|
tltv
approved these changes
Jan 22, 2026
github-project-automation
bot
moved this from 🔎Iteration reviews
to Done
in Vaadin Flow | Hilla | Kits ongoing work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23252