Skip to content

feat: Add HasValidation::bindErrorMessage and bindInvalid #23258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tltv merged 3 commits into from
Jan 22, 2026
Merged

feat: Add HasValidation::bindErrorMessage and bindInvalid #23258

tltv merged 3 commits into from
Jan 22, 2026
+63 −1

Conversation

@mshabarov
Copy link
Contributor

@mshabarov mshabarov commented Jan 20, 2026 •
edited
Loading

Fixes #23257

@github-actions
Copy link

github-actions bot commented Jan 20, 2026 •
edited
Loading

Test Results

1 315 files  ±0  1 315 suites  ±0   1h 14m 24s ⏱️ -26s
9 328 tests ±0  9 260 ✅ ±0  68 💤 ±0  0 ❌ ±0 
9 785 runs  +9  9 709 ✅ +9  76 💤 ±0  0 ❌ ±0 

Results for commit 373f76d. ± Comparison against base commit d4fca88.

♻️ This comment has been updated with latest results.

@mshabarov mshabarov mentioned this pull request Jan 20, 2026
Merged
@mshabarov mshabarov changed the title feat: Add HasValidation::bindErrorMessage feat: Add HasValidation::bindErrorMessage and bindInvalid Jan 21, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 21, 2026

Quality Gate Passed Quality Gate passed

Issues
2551 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mshabarov mshabarov requested a review from tltv January 22, 2026 07:23
@tltv
Copy link
Member

tltv commented Jan 22, 2026

This doesn't have actual implementations, what's the plan for classes implementing this interface?

@mshabarov
Copy link
Contributor Author

mshabarov commented Jan 22, 2026

HasValidation is implemented in components through the HasValidationProperties, where these new methods delegate to property bindings.

vaadin/flow-components#8509

@tltv tltv merged commit 2ec34d6 into main Jan 22, 2026
31 checks passed
@tltv tltv deleted the bind-error-message branch January 22, 2026 11:00
@github-project-automation github-project-automation bot moved this from 🔎Iteration reviews to Done in Vaadin Flow | Hilla | Kits ongoing work Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tltv tltv tltv approved these changes

Assignees

No one assigned

Labels

signals +0.1.0

Projects

Vaadin Flow | Hilla | Kits ongoing work
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement HasValidation::bindErrorMessage(Signal<String>) and HasValidation::bindInvalid(Signal<Boolean>)

3 participants

@mshabarov @tltv