Skip to content

Conversation

@tltv
Copy link
Member

@tltv tltv commented Jan 29, 2026

Adds Binder.getValidationStatus() method to get read-only signal for BinderValidationStatus.

Fixes: #23300

Adds Binder.getValidationStatus() method to get read-only signal for BinderValidationStatus.

Fixes: #23300
@tltv tltv marked this pull request as draft January 30, 2026 08:55
@tltv
Copy link
Member Author

tltv commented Jan 30, 2026

Found an issue with real use cases, converting back to draft for now.

Issue is with single binding validation currently updates the signal with a single field's validation result only, which is not useful in practice. Need to change this to always make sure that signal have whole binder's validation status.

Edit: issue fixed

@mshabarov mshabarov self-requested a review January 30, 2026 08:57
@tltv tltv marked this pull request as ready for review January 30, 2026 09:45
@tltv
Copy link
Member Author

tltv commented Jan 30, 2026

Another issue with real use cases: Binder.readBean(bean) updates status signal in unresolved status, making status.isOk() return true even with invalid data initially.

Edit: fixed

@sonarqubecloud
Copy link

@mshabarov mshabarov merged commit 488224d into feat/binder-signal-validation Feb 3, 2026
9 checks passed
@mshabarov mshabarov deleted the feat/binder-reacting-to-status-change branch February 3, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants