Properly check ancestors for alias child #23411
Merged
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshabarov
previously approved these changes
Feb 9, 2026
| @@ -300,7 +300,7 @@ private void attach(Id parentId, Id childId, ChildAttacher attacher) { | |||
|
|
|||
| Id ancestor = resolvedParentId; | |||
| while (ancestor != null) { | |||
| if (ancestor.equals(childId)) { | |||
| if (ancestor.equals(resolvedChildId)) { | |||
Contributor
There was a problem hiding this comment.
non-blocking: could give more context on what is the bigger problem behind this change.
Member
Author
There was a problem hiding this comment.
Description added to the top-level PR description. Should just make sure the description is used as the commit message when merging.
Member
|
I generated some conflicts for you |
mshabarov
approved these changes
Feb 9, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signal tree logic has a check to verify that a node isn't moved in a way that creates a cyclic graph, i.e. to prevent the node from becoming its own ancestor. Before this fix, the logic was checking based on the provided node id without resolving aliases whereas the actual move was applied with resolved aliases. This made it possible to accidentally move a node in a way that created a cycle by moving an alias of the node rather than the original node. The fix is to resolve any alias before checking for cycles.