Merged
Conversation
Extract the browserDetails earlier so that they are available when UiInitListeners are fired. Fixes #23396
Artur-
reviewed
Feb 5, 2026
| session.addUI(ui); | ||
|
|
||
| // Parse browser details from request parameters and store in UI | ||
| extractAndStoreBrowserDetails(request, ui); |
Member
There was a problem hiding this comment.
Does it make any difference if this is done here or before doIniit?
Contributor
Author
There was a problem hiding this comment.
It should not. I'll update the positioning.
|
mcollovati
approved these changes
Feb 6, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
Extract the browserDetails earlier so that they are available when UiInitListeners are fired. Fixes #23396
mcollovati
pushed a commit
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the browserDetails earlier
so that they are available when
UiInitListeners are fired.
Fixes #23396