fix: add @NonNull value type annotations on collection-based signals#23557
Merged
fix: add @NonNull value type annotations on collection-based signals#23557
Conversation
In a @NullMarked package, type parameters are implicitly @nullable, making peek() return @nullable for ListSignal, SharedListSignal, and SharedMapSignal even though their collection values are never null. Add @nonnull to the type arguments to correctly express this contract. Also add toString() to ListSignal and ValueSignal with corresponding tests, matching the pattern used in shared signal classes.
Member
|
Please do separate PRs for nullability annotations in one subset of signal types and toString of a different subset of signal types. |
These will be handled separately in the localSignalToString branch.
Member
Author
|
Removed toString and tests |
|
Legioth
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a @NullMarked package, type parameters are implicitly @nullable, making peek() return @nullable for ListSignal, SharedListSignal, and SharedMapSignal even though their collection values are never null. Add @nonnull to the type arguments to correctly express this contract.