Skip to content

Comments

fix: Populate ActiveStyleSheetTracker during page load for CSS live reload without HotSwap Agent (#23603) (CP: 25.0)#23635

Merged
mcollovati merged 1 commit into25.0from
cherry/cherrypick-23603-to-25.0
Feb 23, 2026
Merged

fix: Populate ActiveStyleSheetTracker during page load for CSS live reload without HotSwap Agent (#23603) (CP: 25.0)#23635
mcollovati merged 1 commit into25.0from
cherry/cherrypick-23603-to-25.0

Conversation

@mcollovati
Copy link
Collaborator

ActiveStyleSheetTracker was only populated by StyleSheetHotswapper.onInit(), which requires a HotSwap Agent. Without one, the tracker stayed empty and PublicResourcesLiveUpdater's file watcher silently skipped all CSS updates.

Register active @Stylesheet URLs during normal dev-mode page loading:

  • AppShellRegistry.createSettings() tracks AppShell stylesheets
  • UIInternals.addComponentDependencies() tracks component stylesheets

Both paths are guarded by !isProductionMode() for zero production overhead.

Also simplify the live reload integration test to rely on the file watcher instead of manually triggering reload via button clicks.

Fixes #23592

…eload without HotSwap Agent (#23603)

ActiveStyleSheetTracker was only populated by StyleSheetHotswapper.onInit(),
which requires a HotSwap Agent. Without one, the tracker stayed empty and
PublicResourcesLiveUpdater's file watcher silently skipped all CSS updates.

Register active @Stylesheet URLs during normal dev-mode page loading:
- AppShellRegistry.createSettings() tracks AppShell stylesheets
- UIInternals.addComponentDependencies() tracks component stylesheets

Both paths are guarded by !isProductionMode() for zero production overhead.

Also simplify the live reload integration test to rely on the file watcher
instead of manually triggering reload via button clicks.

Fixes #23592
@sonarqubecloud
Copy link

@mcollovati mcollovati enabled auto-merge (squash) February 23, 2026 11:05
@github-actions
Copy link

Test Results

1 314 files  ±0  1 314 suites  ±0   1h 18m 15s ⏱️ - 1m 8s
9 312 tests ±0  9 244 ✅ ±0  68 💤 ±0  0 ❌ ±0 
9 771 runs  +1  9 695 ✅ +1  76 💤 ±0  0 ❌ ±0 

Results for commit 01b1175. ± Comparison against base commit d97722c.

@mcollovati mcollovati merged commit 1cde734 into 25.0 Feb 23, 2026
30 checks passed
@mcollovati mcollovati deleted the cherry/cherrypick-23603-to-25.0 branch February 23, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants