feat: BuildFrontend Incremental build by caalador · Pull Request #23884 · vaadin/flow

caalador · 2026-03-16T07:17:28Z

Add incremental build to the
buildFrontend task.

Add incremental build to the buildFrontend task. Closes #17354

github-actions · 2026-03-16T07:53:39Z

Test Results

1 387 files ±0 1 387 suites ±0 1h 30m 51s ⏱️ + 3m 8s
9 923 tests ±0 9 852 ✅ ±0 71 💤 ±0 0 ❌ ±0
10 396 runs ±0 10 316 ✅ ±0 80 💤 ±0 0 ❌ ±0

Results for commit 827d4fb. ± Comparison against base commit 03c9d39.

♻️ This comment has been updated with latest results.

mcollovati

Would it be possible to add a couple of tests in MiscSingleModuleTest (similar to prepareFrontendIncrementalBuilds_featureEnabled and related) to ensure that a frontend build is performed only if an input change is detected or if the build is explicitly forced by the new alwaysExecuteBuildFrontend flag?

Also, do we need to take configuration cache into account, like in VaadinSmokeTest.testPrepareFrontend_configurationCache?

caalador · 2026-03-17T06:32:07Z

Added tests.

BuildFrontend can not cache configurations as it uses the Project Object as execution time which is not allowed for caching configuration.

do not use prod bundle as the version is set to 1111.5.0-SNAPSHOT or the like

flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinBuildFrontendTask.kt

...plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/BuildFrontendInputProperties.kt

This reverts commit 500da88.

flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinBuildFrontendTask.kt

Fix WEBPACK to VITE

sonarqubecloud · 2026-03-17T13:45:55Z

Quality Gate passed

Issues
1437 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Add incremental build to the buildFrontend task. Closes #17354

vaadin-bot · 2026-03-17T14:20:43Z

Hi @caalador and @mcollovati, when i performed cherry-pick to this commit to 24.10, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 88408e7
error: could not apply 88408e7... feat: BuildFrontend Incremental build (#23884)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Add incremental build to the buildFrontend task. Closes #17354

vaadin-bot · 2026-03-17T14:20:58Z

Hi @caalador and @mcollovati, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 88408e7
error: could not apply 88408e7... feat: BuildFrontend Incremental build (#23884)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Add incremental build to the buildFrontend task. Closes #17354 Co-authored-by: caalador <mikael.grankvist@vaadin.com>

This reverts commit a83a454.

This reverts commit 31a34c9.

This reverts commit a83a454.

feat: BuildFrontend Incremental build

796f4a7

Add incremental build to the buildFrontend task. Closes #17354

github-actions bot added the +1.0.0 label Mar 16, 2026

caalador marked this pull request as ready for review March 16, 2026 09:47

caalador and others added 2 commits March 16, 2026 12:37

remove commented out targets

151907f

Merge branch 'main' into issues/17354-build-frontend-up-to-date

05e8854

github-actions bot added +0.0.1 and removed +1.0.0 labels Mar 16, 2026

caalador added target/24.9 target/25.0 Cherry-pick to 25.0 branch target/24.10 target/25.1 labels Mar 16, 2026

mshabarov requested a review from mcollovati March 16, 2026 12:34

mcollovati reviewed Mar 16, 2026

View reviewed changes

Add cache tests

ee0b1bc

github-actions bot added +1.0.0 and removed +0.0.1 labels Mar 17, 2026

caalador and others added 4 commits March 17, 2026 09:11

Remove configurationCache tests

500da88

BuildFrontend can not cache configurations as it uses the Project Object as execution time which is not allowed for caching configuration.

fix incremental targets

c3010e5

Remove prod bundle dependency

acff593

do not use prod bundle as the version is set to 1111.5.0-SNAPSHOT or the like

Merge branch 'main' into issues/17354-build-frontend-up-to-date

061ade7

github-actions bot added +0.0.1 and removed +1.0.0 labels Mar 17, 2026

mcollovati requested changes Mar 17, 2026

View reviewed changes

caalador added 4 commits March 17, 2026 12:47

fix comment postition and content

5e49f33

use output marker to have same if changed

e9d91ac

move fingerprint to configure

57f6bf0

Revert "Remove configurationCache tests"

04dc8fd

This reverts commit 500da88.

mcollovati reviewed Mar 17, 2026

View reviewed changes

flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinBuildFrontendTask.kt Outdated Show resolved Hide resolved

mcollovati reviewed Mar 17, 2026

View reviewed changes

flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinBuildFrontendTask.kt Outdated Show resolved Hide resolved

mcollovati reviewed Mar 17, 2026

View reviewed changes

flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinBuildFrontendTask.kt Outdated Show resolved Hide resolved

Remove unused imports

827d4fb

Fix WEBPACK to VITE

mcollovati approved these changes Mar 17, 2026

View reviewed changes

mcollovati merged commit 88408e7 into main Mar 17, 2026
32 checks passed

mcollovati deleted the issues/17354-build-frontend-up-to-date branch March 17, 2026 14:08

vaadin-bot pushed a commit that referenced this pull request Mar 17, 2026

feat: BuildFrontend Incremental build (#23884)

fa3bd31

Add incremental build to the buildFrontend task. Closes #17354

vaadin-bot added the cherry-picked-25.1 label Mar 17, 2026

vaadin-bot mentioned this pull request Mar 17, 2026

feat: BuildFrontend Incremental build (#23884) (CP: 25.1) #23920

Merged

vaadin-bot added the need to pick manually 24.10 label Mar 17, 2026

vaadin-bot pushed a commit that referenced this pull request Mar 17, 2026

feat: BuildFrontend Incremental build (#23884)

2ec6aa2

Add incremental build to the buildFrontend task. Closes #17354

vaadin-bot mentioned this pull request Mar 17, 2026

feat: BuildFrontend Incremental build (#23884) (CP: 25.0) #23921

Merged

vaadin-bot added cherry-picked-25.0 need to pick manually 24.9 labels Mar 17, 2026

vaadin-bot added a commit that referenced this pull request Mar 17, 2026

feat: BuildFrontend Incremental build (#23884) (#23920)

31a34c9

Add incremental build to the buildFrontend task. Closes #17354 Co-authored-by: caalador <mikael.grankvist@vaadin.com>

vaadin-bot added a commit that referenced this pull request Mar 17, 2026

feat: BuildFrontend Incremental build (#23884) (#23921)

a83a454

Add incremental build to the buildFrontend task. Closes #17354 Co-authored-by: caalador <mikael.grankvist@vaadin.com>

caalador added a commit that referenced this pull request Mar 18, 2026

Revert "feat: BuildFrontend Incremental build (#23884) (#23921)"

5484826

This reverts commit a83a454.

caalador added a commit that referenced this pull request Mar 18, 2026

Revert "feat: BuildFrontend Incremental build (#23884) (#23920)"

9fd2587

This reverts commit 31a34c9.

mshabarov pushed a commit that referenced this pull request Mar 18, 2026

Revert "feat: BuildFrontend Incremental build (#23884) (#23920)"

cd1a5d2

This reverts commit 31a34c9.

mshabarov pushed a commit that referenced this pull request Mar 18, 2026

Revert "feat: BuildFrontend Incremental build (#23884) (#23921)"

1944555

This reverts commit a83a454.

caalador removed target/24.9 need to pick manually 24.9 target/24.10 need to pick manually 24.10 labels Mar 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: BuildFrontend Incremental build#23884

feat: BuildFrontend Incremental build#23884
mcollovati merged 13 commits intomainfrom
issues/17354-build-frontend-up-to-date

caalador commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

mcollovati left a comment

Uh oh!

caalador commented Mar 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 17, 2026

Uh oh!

Uh oh!

vaadin-bot commented Mar 17, 2026

Uh oh!

vaadin-bot commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

caalador commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

mcollovati left a comment

Choose a reason for hiding this comment

Uh oh!

caalador commented Mar 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 17, 2026

Quality Gate passed

Uh oh!

Uh oh!

vaadin-bot commented Mar 17, 2026

Uh oh!

vaadin-bot commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Mar 16, 2026 •

edited

Loading