fix: Prevent stale JAR cache in ReflectionsClassFinder under Gradle daemon (CP: 24.9)#23969
Merged
mcollovati merged 2 commits into24.9from Mar 24, 2026
Merged
fix: Prevent stale JAR cache in ReflectionsClassFinder under Gradle daemon (CP: 24.9)#23969mcollovati merged 2 commits into24.9from
ReflectionsClassFinder under Gradle daemon (CP: 24.9)#23969mcollovati merged 2 commits into24.9from
Conversation
… daemon Close `URLClassLoader` on cleanup to release JAR file handles, and disable JVM-level JAR caching in `getResource()` by wrapping `jar:` URLs with a `URLStreamHandler` that sets `useCaches(false)`. The Gradle daemon reuses JVMs across builds. When a sibling module's JAR is rewritten, two independent caching layers can hold stale file handles: 1. `URLClassLoader` internal cache (`URLClassPath` → `JarLoader`) 2. `JarFileFactory` static HashMap (populated via `JarURLConnection`) The `URLClassLoader.close()` call addresses layer 1, but layer 2 is JVM-global and independent of the class loader. Setting `useCaches(false)` on `jar:` URL connections prevents `JarFileFactory` from caching `JarFile` instances, matching the approach used by Spring's `PathMatchingResourcePatternResolver` (SPR-4639). Fixes #15458
caalador
previously approved these changes
Mar 24, 2026
Comment on lines
86
to
87
| val tokenFile = BuildFrontendUtil.getTokenFile(adapter.get()) | ||
| check(tokenFile.exists()) { "token file $tokenFile doesn't exist!" } |
Contributor
There was a problem hiding this comment.
These lines have not bee formatted to correct indentation after the added try{}
mcollovati
changed the title
ReflectionsClassFinder under Gradle daemon (24.9)ReflectionsClassFinder under Gradle daemon (CP: 24.9)
caalador
approved these changes
Mar 24, 2026
|
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
… daemon (CP: 24.9) (#23969) Close `URLClassLoader` on cleanup to release JAR file handles, and disable JVM-level JAR caching in `getResource()` by wrapping `jar:` URLs with a `URLStreamHandler` that sets `useCaches(false)`. The Gradle daemon reuses JVMs across builds. When a sibling module's JAR is rewritten, two independent caching layers can hold stale file handles: 1. `URLClassLoader` internal cache (`URLClassPath` → `JarLoader`) 2. `JarFileFactory` static HashMap (populated via `JarURLConnection`) The `URLClassLoader.close()` call addresses layer 1, but layer 2 is JVM-global and independent of the class loader. Setting `useCaches(false)` on `jar:` URL connections prevents `JarFileFactory` from caching `JarFile` instances, matching the approach used by Spring's `PathMatchingResourcePatternResolver` (SPR-4639). Fixes #15458
vaadin-bot
added a commit
that referenced
this pull request
Mar 24, 2026
… daemon (CP: 24.9) (#23969) (#23976) Close `URLClassLoader` on cleanup to release JAR file handles, and disable JVM-level JAR caching in `getResource()` by wrapping `jar:` URLs with a `URLStreamHandler` that sets `useCaches(false)`. The Gradle daemon reuses JVMs across builds. When a sibling module's JAR is rewritten, two independent caching layers can hold stale file handles: 1. `URLClassLoader` internal cache (`URLClassPath` → `JarLoader`) 2. `JarFileFactory` static HashMap (populated via `JarURLConnection`) The `URLClassLoader.close()` call addresses layer 1, but layer 2 is JVM-global and independent of the class loader. Setting `useCaches(false)` on `jar:` URL connections prevents `JarFileFactory` from caching `JarFile` instances, matching the approach used by Spring's `PathMatchingResourcePatternResolver` (SPR-4639). Fixes #15458 Co-authored-by: Marco Collovati <marco@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close
URLClassLoaderon cleanup to release JAR file handles, and disable JVM-level JAR caching ingetResource()by wrappingjar:URLs with aURLStreamHandlerthat setsuseCaches(false).The Gradle daemon reuses JVMs across builds. When a sibling module's JAR is rewritten, two independent caching layers can hold stale file handles:
URLClassLoaderinternal cache (URLClassPath→JarLoader)JarFileFactorystatic HashMap (populated viaJarURLConnection)The
URLClassLoader.close()call addresses layer 1, but layer 2 is JVM-global and independent of the class loader. SettinguseCaches(false)onjar:URL connections preventsJarFileFactoryfrom cachingJarFileinstances, matching the approach used by Spring'sPathMatchingResourcePatternResolver(SPR-4639).Fixes #15458