fix: Fix signal effect dispatching for test environments#24041
Merged
Conversation
Add registerFirst() to SignalEnvironment so test environments can take priority over VaadinServiceEnvironment for effect dispatching. Add inner UI.getCurrent() check in ElementEffect's dispatched effect lambda so effects run directly on the test thread (where UI.getCurrent() matches the target UI) instead of going through ui.access(), which would enqueue to the session's pending access queue without executing.
Member
Author
|
Related to vaadin/browserless-test#28 |
Legioth
requested changes
Mar 30, 2026
Artur-
added a commit
that referenced
this pull request
Mar 30, 2026
After calling getDriver().navigate().refresh(), the test immediately queried for the element without waiting for the page to actually reload. This caused a NoSuchElementException when the DOM was in a transitional state. The fix waits for the old element to become stale (confirming the page has started unloading) and then waits for the new element to appear before asserting on it. Fixes #24041
|
Legioth
approved these changes
Mar 30, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
Add registerFirst() to SignalEnvironment so test environments can take priority over VaadinServiceEnvironment for effect dispatching. Add inner UI.getCurrent() check in ElementEffect's dispatched effect lambda so effects run directly on the test thread (where UI.getCurrent() matches the target UI) instead of going through ui.access(), which would enqueue to the session's pending access queue without executing.
vaadin-bot
added a commit
that referenced
this pull request
Mar 30, 2026
…: 25.1) (#24046) This PR cherry-picks changes from the original PR #24041 to branch 25.1. --- #### Original PR description > Add registerFirst() to SignalEnvironment so test environments can take priority over VaadinServiceEnvironment for effect dispatching. > > Add inner UI.getCurrent() check in ElementEffect's dispatched effect lambda so effects run directly on the test thread (where UI.getCurrent() matches the target UI) instead of going through ui.access(), which would enqueue to the session's pending access queue without executing. > Co-authored-by: Artur Signell <artur@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add registerFirst() to SignalEnvironment so test environments can take priority over VaadinServiceEnvironment for effect dispatching.
Add inner UI.getCurrent() check in ElementEffect's dispatched effect lambda so effects run directly on the test thread (where UI.getCurrent() matches the target UI) instead of going through ui.access(), which would enqueue to the session's pending access queue without executing.