Skip to content

feat: expose application properties via Options for TypeScriptBootstrapModifier consumers#24073

Merged
mcollovati merged 1 commit intomainfrom
issues/24055-options_application_properties
Apr 9, 2026
Merged

feat: expose application properties via Options for TypeScriptBootstrapModifier consumers#24073
mcollovati merged 1 commit intomainfrom
issues/24055-options_application_properties

Conversation

@mcollovati
Copy link
Copy Markdown
Collaborator

TypeScriptBootstrapModifier implementations (e.g., Copilot) need access
to application properties to conditionally modify bootstrap TypeScript.
Currently, the Copilot script is injected in dev mode regardless of
whether Copilot is enabled in the project configuration.

Add withApplicationConfiguration to Options and property accessor
methods (getApplicationStringProperty, getApplicationBooleanProperty)
that return Optional.empty() when configuration is unavailable (build
time). Wire ApplicationConfiguration from DevModeInitializer.

Fixes #24055

@github-actions github-actions bot added the +0.1.0 label Apr 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Test Results

 1 388 files  +1   1 388 suites  +1   1h 24m 31s ⏱️ + 2m 29s
 9 942 tests +4   9 871 ✅ +4  71 💤 ±0  0 ❌ ±0 
10 415 runs  +4  10 335 ✅ +4  80 💤 ±0  0 ❌ ±0 

Results for commit a7501f2. ± Comparison against base commit 9ea2d00.

♻️ This comment has been updated with latest results.

…strapModifier` consumers

`TypeScriptBootstrapModifier` implementations (e.g., Copilot) need access
to application properties to conditionally modify bootstrap TypeScript.
Currently, the Copilot script is injected in dev mode regardless of
whether Copilot is enabled in the project configuration.

Add `withApplicationConfiguration` to `Options` and property accessor
methods (`getApplicationStringProperty`, `getApplicationBooleanProperty`)
that return `Optional.empty()` when configuration is unavailable (build
time). Wire `ApplicationConfiguration` from `DevModeInitializer`.

Fixes #24055
@mcollovati mcollovati force-pushed the issues/24055-options_application_properties branch from 0ff4e43 to a7501f2 Compare April 7, 2026 14:08
@mcollovati mcollovati marked this pull request as ready for review April 7, 2026 14:08
@github-actions github-actions bot added +0.0.1 and removed +0.1.0 labels Apr 7, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

@mcollovati mcollovati added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit 727464d Apr 9, 2026
31 checks passed
@mcollovati mcollovati deleted the issues/24055-options_application_properties branch April 9, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add copilotEnabled option for TypeScriptBootstrapModifier consumers

2 participants