Skip to content

fix: fix potential deadlock in AtmospherePushConnection disconnect#24133

Merged
mcollovati merged 1 commit intomainfrom
issues/24129-pushconnection_deadlock
Apr 21, 2026
Merged

fix: fix potential deadlock in AtmospherePushConnection disconnect#24133
mcollovati merged 1 commit intomainfrom
issues/24129-pushconnection_deadlock

Conversation

@mcollovati
Copy link
Copy Markdown
Collaborator

@mcollovati mcollovati commented Apr 16, 2026 •
edited
Loading

Fixes #24129

@mcollovati mcollovati marked this pull request as draft April 16, 2026 08:55
@mcollovati mcollovati force-pushed the issues/24129-pushconnection_deadlock branch from 66cb498 to 59039d8 Compare April 16, 2026 09:01
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 16, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

Test Results

 1 391 files  ±0   1 391 suites  ±0   1h 14m 49s ⏱️ - 1m 13s
 9 997 tests ±0   9 926 ✅ ±0  71 💤 ±0  0 ❌ ±0 
10 472 runs  ±0  10 392 ✅ ±0  80 💤 ±0  0 ❌ ±0 

Results for commit 59039d8. ± Comparison against base commit 495ee33.

@mcollovati
Copy link
Copy Markdown
Collaborator Author

mcollovati commented Apr 17, 2026

Waiting for feedback

@johannest johannest mentioned this pull request Apr 21, 2026
Closed
@johannest
Copy link
Copy Markdown
Contributor

johannest commented Apr 21, 2026

This fix was extensively tested in the environment where the issue was previously reproduced: Now the deadlock does not reproduce anymore: fix seems to work well

@mcollovati mcollovati marked this pull request as ready for review April 21, 2026 14:01
@mcollovati mcollovati enabled auto-merge April 21, 2026 14:07
@mcollovati mcollovati added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit 7b077e9 Apr 21, 2026
31 checks passed
@mcollovati mcollovati deleted the issues/24129-pushconnection_deadlock branch April 21, 2026 14:26
This was referenced Apr 21, 2026
Merged
Merged
@vaadin-bot vaadin-bot mentioned this pull request Apr 21, 2026
Merged
@vaadin-bot vaadin-bot mentioned this pull request Apr 21, 2026
Merged
@vaadin-bot vaadin-bot mentioned this pull request Apr 21, 2026
Merged
@vaadin-bot vaadin-bot mentioned this pull request Apr 21, 2026
Merged
vaadin-bot added a commit that referenced this pull request Apr 21, 2026
@vaadin-bot @mcollovati
fix: fix potential deadlock in AtmospherePushConnection disconnect (#…
db39876 
…24133) (CP: 23.7) (#24159)

This PR cherry-picks changes from the original PR #24133 to branch 23.7.
---
#### Original PR description
> Fixes #24129

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Apr 21, 2026
@vaadin-bot @mcollovati
fix: fix potential deadlock in AtmospherePushConnection disconnect (#…
51b4e65 
…24133) (CP: 23.6) (#24161)

This PR cherry-picks changes from the original PR #24133 to branch 23.6.
---
#### Original PR description
> Fixes #24129

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Apr 21, 2026
@vaadin-bot @mcollovati
fix: fix potential deadlock in AtmospherePushConnection disconnect (#…
076385f 
…24133) (CP: 25.0) (#24158)

This PR cherry-picks changes from the original PR #24133 to branch 25.0.
---
#### Original PR description
> Fixes #24129

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Apr 21, 2026
@vaadin-bot @mcollovati
fix: fix potential deadlock in AtmospherePushConnection disconnect (#…
4ea30a7 
…24133) (CP: 25.1) (#24156)

This PR cherry-picks changes from the original PR #24133 to branch 25.1.
---
#### Original PR description
> Fixes #24129

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Apr 21, 2026
@vaadin-bot @mcollovati
fix: fix potential deadlock in AtmospherePushConnection disconnect (#…
8eb5d5d 
…24133) (CP: 24.10) (#24157)

This PR cherry-picks changes from the original PR #24133 to branch
24.10.
---
#### Original PR description
> Fixes #24129

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Apr 21, 2026
@vaadin-bot @mcollovati
fix: fix potential deadlock in AtmospherePushConnection disconnect (#…
a7176db 
…24133) (CP: 24.9) (#24160)

This PR cherry-picks changes from the original PR #24133 to branch 24.9.
---
#### Original PR description
> Fixes #24129

Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Artur- Artur- Artur- approved these changes

Assignees

No one assigned

Labels

cherry-picked-23.6 cherry-picked-23.7 cherry-picked-24.9 cherry-picked-24.10 cherry-picked-25.0 cherry-picked-25.1 target/23.6 target/23.7 target/24.9 target/24.10 target/25.0 Cherry-pick to 25.0 branch target/25.1 +0.0.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AtmospherePushConnection.disconnect() deadlocks with containers that synchronize on HttpSession

4 participants

@mcollovati @johannest @Artur- @vaadin-bot