fix: add package.json overrides for workbox dependencies (#24008) (CP: 24.10)#24163
Merged
fix: add package.json overrides for workbox dependencies (#24008) (CP: 24.10)#24163
Conversation
…: 24.10) - Add PwaConfiguration parameter to TaskUpdateVite constructor - Remove service worker plugin and its imports from vite.generated.ts when offline build is not enabled - Use FrontendDependenciesScanner in TaskGeneratePackageJson to generate correct dev dependencies - Enhance TaskUpdatePackages for proper override handling - Move all workbox dependencies to `workbox/package.json` and only add when offline sw build is needed - Add overrides for workbox dependencies to package.json - Add overrides support to NodeUpdater - Remove empty vaadin.overrides from package.json (cherry picked from commit 90eb196)
Adjust the checks for user opt-out in package.json overrides, so that an existing override for new entries added by Vaadin is considered as an opt-out, so that the existing user value is kept. This behavior satisfies the previously existing `NodeUpdatePackagesNpmVersionLockingTest.shouldNotUpdatesOverrides_whenHasUserModification` test. (cherry picked from commit 070e32c)
… (CP: 24.10) Adjust user opt-out override detection for `package.json` without explicitly stored previous Vaadin overrides to still upgrade old override versions of Vaadin managed dependencies. Fixes the build issues for https://github.com/vaadin/patient-portal-demo-flow (cherry picked from commit 2d312d2)
|
ZheSun88
approved these changes
Apr 23, 2026
Collaborator
|
Hi @platosha and @ZheSun88, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually? |
Contributor
|
cp 24.9 : #24176 |
platosha
added a commit
that referenced
this pull request
Apr 24, 2026
…4163) (CP:24.9) (#24176) - Add PwaConfiguration parameter to TaskUpdateVite constructor - Remove service worker plugin and its imports from vite.generated.ts when offline build is not enabled - Use FrontendDependenciesScanner in TaskGeneratePackageJson to generate correct dev dependencies - Enhance TaskUpdatePackages for proper override handling - Move all workbox dependencies to `workbox/package.json` and only add when offline sw build is needed - Add overrides for workbox dependencies to package.json - Add overrides support to NodeUpdater - Remove empty vaadin.overrides from package.json (cherry picked from commit 90eb196) Co-authored-by: Anton Platonov <anton@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when offline build is not enabled
correct dev dependencies
workbox/package.jsonand only addwhen offline sw build is needed
(cherry picked from commit 90eb196)