Skip to content

fix: expose vaadin.eagerServerLoad in Spring properties metadata#24168

Merged
mshabarov merged 2 commits intovaadin:mainfrom
wutzebaer:fix/spring-metadata-eager-server-load
Apr 23, 2026
Merged

fix: expose vaadin.eagerServerLoad in Spring properties metadata#24168
mshabarov merged 2 commits intovaadin:mainfrom
wutzebaer:fix/spring-metadata-eager-server-load

Conversation

@wutzebaer
Copy link
Copy Markdown
Contributor

@wutzebaer wutzebaer commented Apr 23, 2026

Add eagerServerLoad to VaadinConfigurationProperties so Spring Boot can generate configuration metadata and IDE autocomplete for the documented vaadin.eagerServerLoad property.

Made-with: Cursor

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Apr 23, 2026

CLA assistant check
All committers have signed the CLA.

Add eagerServerLoad to VaadinConfigurationProperties so Spring Boot can generate configuration metadata and IDE autocomplete for the documented vaadin.eagerServerLoad property.

Made-with: Cursor
@wutzebaer wutzebaer force-pushed the fix/spring-metadata-eager-server-load branch from 81cd1aa to 89faa7c Compare April 23, 2026 07:00
@mshabarov mshabarov added the Contribution PRs coming from the community or external to the team label Apr 23, 2026
@mshabarov
Copy link
Copy Markdown
Contributor

mshabarov commented Apr 23, 2026

Looks good to me, thanks for contribution!

One thing to keep in mind: properties in this class make IDE hints work for editing application.properties, but if one wants to programmatically calling setEagerServerLoad(...) at runtime (or any of other setters in this class), e.g. through the autowired VaadinConfigurationProperties instance, they they'll be no-op.

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Test Results

 1 391 files  ±0   1 391 suites  ±0   1h 16m 44s ⏱️ -39s
10 006 tests ±0   9 936 ✅ ±0  70 💤 ±0  0 ❌ ±0 
10 481 runs  ±0  10 402 ✅ ±0  79 💤 ±0  0 ❌ ±0 

Results for commit 301fa7b. ± Comparison against base commit 7005a25.

@mshabarov mshabarov added this pull request to the merge queue Apr 23, 2026
@mshabarov mshabarov added target/25.0 Cherry-pick to 25.0 branch target/25.1 labels Apr 23, 2026
Merged via the queue into vaadin:main with commit 1245d90 Apr 23, 2026
31 checks passed
vaadin-bot added a commit that referenced this pull request Apr 23, 2026
) (CP: 25.0) (#24174)

This PR cherry-picks changes from the original PR #24168 to branch 25.0.
---
#### Original PR description
> Add eagerServerLoad to VaadinConfigurationProperties so Spring Boot
can generate configuration metadata and IDE autocomplete for the
documented vaadin.eagerServerLoad property.
> 
> Made-with: Cursor
> 
> <!-- PLEASE READ AND FOLLOW THE TEMPLATE! THE PR CAN BE REJECTED
OTHERWISE (This line should be removed when submitting) -->
> 
> ## Description
> 
> Please list all relevant dependencies in this section and provide
summary of the change, motivation and context.
> 
> Fixes # (issue)
> 
> ## Type of change
> 
> - [ ] Bugfix
> - [x] Feature
> 
> ## Checklist
> 
> - [x] I have read the contribution guide:
https://vaadin.com/docs/latest/guide/contributing/overview/
> - [x] I have added a description following the guideline.
> - [x] The issue is created in the corresponding repository and I have
referenced it.
> - [x] I have added tests to ensure my change is effective and works as
intended.
> - [x] New and existing tests are passing locally with my change.
> - [x] I have performed self-review and corrected misspellings.
> 
> #### Additional for `Feature` type of change
> 
> - [ ] Enhancement / new feature was discussed in a corresponding
GitHub issue and Acceptance Criteria were created.
>

Co-authored-by: Peter Großmann <petergrossmann@email.de>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
vaadin-bot added a commit that referenced this pull request Apr 23, 2026
) (CP: 25.1) (#24173)

This PR cherry-picks changes from the original PR #24168 to branch 25.1.
---
#### Original PR description
> Add eagerServerLoad to VaadinConfigurationProperties so Spring Boot
can generate configuration metadata and IDE autocomplete for the
documented vaadin.eagerServerLoad property.
> 
> Made-with: Cursor
> 
> <!-- PLEASE READ AND FOLLOW THE TEMPLATE! THE PR CAN BE REJECTED
OTHERWISE (This line should be removed when submitting) -->
> 
> ## Description
> 
> Please list all relevant dependencies in this section and provide
summary of the change, motivation and context.
> 
> Fixes # (issue)
> 
> ## Type of change
> 
> - [ ] Bugfix
> - [x] Feature
> 
> ## Checklist
> 
> - [x] I have read the contribution guide:
https://vaadin.com/docs/latest/guide/contributing/overview/
> - [x] I have added a description following the guideline.
> - [x] The issue is created in the corresponding repository and I have
referenced it.
> - [x] I have added tests to ensure my change is effective and works as
intended.
> - [x] New and existing tests are passing locally with my change.
> - [x] I have performed self-review and corrected misspellings.
> 
> #### Additional for `Feature` type of change
> 
> - [ ] Enhancement / new feature was discussed in a corresponding
GitHub issue and Acceptance Criteria were created.
>

Co-authored-by: Peter Großmann <petergrossmann@email.de>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked-25.0 cherry-picked-25.1 Contribution PRs coming from the community or external to the team target/25.0 Cherry-pick to 25.0 branch target/25.1 +0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants