chore: remove zt-exec dependency#24219
Merged
Merged
Conversation
The Maven plugin used `org.zeroturnaround:zt-exec` to launch the Vite build process, adding an external dependency that had to be pinned on the plugin classpath. Replace it with `java.lang.ProcessBuilder`, following the approach already used elsewhere in Flow for running external processes.
Artur-
reviewed
Apr 30, 2026
| Collections.emptyMap(), "build"); | ||
| } | ||
|
|
||
| // The declared TimeoutException is retained for source compatibility with |
Member
There was a problem hiding this comment.
Shouldn't the throws be removed instead? It's a util class for our plugins
| Runtime.getRuntime().addShutdownHook(shutdownHook); | ||
|
|
||
| StringBuilder toolOutput = new StringBuilder(); | ||
| try (BufferedReader reader = new BufferedReader( |
Member
There was a problem hiding this comment.
This looks like a util method that either exists in Java or in Flow. Files.readAllLines if it is not important to print while reading, something else otherwise
After removing `zt-exec`, the Vite runner still declared `throws TimeoutException` for source compatibility and drained the process output with a manual `BufferedReader` loop. Neither is needed for an internal plugin utility. Drop the unused throws clause (and its multi-catch in `BuildFrontendMojo`) and read the output via `Process.inputReader` plus `BufferedReader.lines().forEach`.
|
caalador
approved these changes
Apr 30, 2026
Collaborator
|
Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 25.0, i have encountered the following issue. Can you take a look and pick it manually? |
vaadin-bot
added a commit
that referenced
this pull request
Apr 30, 2026
This PR cherry-picks changes from the original PR #24219 to branch 25.1. --- #### Original PR description > The Maven plugin used `org.zeroturnaround:zt-exec` to launch the Vite build process, adding an external dependency that had to be pinned on the plugin classpath. > > Replace it with `java.lang.ProcessBuilder`, following the approach already used elsewhere in Flow for running external processes. > Co-authored-by: Marco Collovati <marco@vaadin.com>
Artur-
pushed a commit
that referenced
this pull request
May 1, 2026
The Maven plugin used `org.zeroturnaround:zt-exec` to launch the Vite build process, adding an external dependency that had to be pinned on the plugin classpath. Replace it with `java.lang.ProcessBuilder`, following the approach already used elsewhere in Flow for running external processes.
Artur-
pushed a commit
that referenced
this pull request
May 1, 2026
The Maven plugin used `org.zeroturnaround:zt-exec` to launch the Vite build process, adding an external dependency that had to be pinned on the plugin classpath. Replace it with `java.lang.ProcessBuilder`, following the approach already used elsewhere in Flow for running external processes.
Artur-
pushed a commit
that referenced
this pull request
May 1, 2026
The Maven plugin used `org.zeroturnaround:zt-exec` to launch the Vite build process, adding an external dependency that had to be pinned on the plugin classpath. Replace it with `java.lang.ProcessBuilder`, following the approach already used elsewhere in Flow for running external processes.
vaadin-bot
added a commit
that referenced
this pull request
May 1, 2026
… 24.9) (#24237) This PR cherry-picks changes from the original PR #24224 to branch 24.9. --- #### Original PR description > The Maven plugin used `org.zeroturnaround:zt-exec` to launch the Vite build process, adding an external dependency that had to be pinned on the plugin classpath. > > Replace it with `java.lang.ProcessBuilder`, following the approach already used elsewhere in Flow for running external processes. Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
May 1, 2026
…23.6) (#24238) This PR cherry-picks changes from the original PR #24228 to branch 23.6. --- #### Original PR description > The Maven plugin used `org.zeroturnaround:zt-exec` to launch the Vite build process, adding an external dependency that had to be pinned on the plugin classpath. > > Replace it with `java.lang.ProcessBuilder`, following the approach already used elsewhere in Flow for running external processes. Co-authored-by: Marco Collovati <marco@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Maven plugin used
org.zeroturnaround:zt-execto launch the Vite build process, adding an external dependency that had to be pinned on the plugin classpath.Replace it with
java.lang.ProcessBuilder, following the approach already used elsewhere in Flow for running external processes.