Conversation
Expose UI.routerStateSignal() as a read-only Signal<RouterState> holding the current Location, RouteParameters, active chain and navigation target class. The signal is updated atomically alongside AfterNavigationEvent dispatch, so reactive consumers and listeners observe the same state. Lets components observe the active route via Signal.effect instead of registering an AfterNavigationListener and manually fetching the initial state from UIInternals on attach. Fine-grained projections (current location, route parameters, leaf view) are derivable with Signal.map; two-way URL/parameter binding is intentionally left for a follow-up so its API can be designed independently.
Shared RouterStateLayout subscribes to UI.routerStateSignal() and renders the active path, navigation target class, route parameters and an update counter. Two views (A and B/:id?) navigate between each other and self-navigate with different route parameters. The IT verifies the layout's display tracks each navigation, that self-navigation with a new :id parameter still triggers an update, and that an unrelated UI mutation (UI.setLocale) does NOT fire the router signal.
The route value uses the FQN, so the rendered path is "com.vaadin.flow.uitest.ui.routerstate.RouterStateBView/99". The earlier waitForPath calls already use endsWith; the strict assertEquals on the locale-step assertion didn't, causing the IT to fail in CI. Switch it to endsWith for consistency.
|
heruan
approved these changes
May 6, 2026
Member
heruan
left a comment
heruan
left a comment
There was a problem hiding this comment.
Clean addition that mirrors the existing localeSignal() pattern. Test coverage is solid. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose UI.routerStateSignal() as a read-only Signal holding the current Location, RouteParameters, active chain and navigation target class. The signal is updated atomically alongside AfterNavigationEvent dispatch, so reactive consumers and listeners observe the same state.
Lets components observe the active route via Signal.effect instead of registering an AfterNavigationListener and manually fetching the initial state from UIInternals on attach. Fine-grained projections (current location, route parameters, leaf view) are derivable with Signal.map; two-way URL/parameter binding is intentionally left for a follow-up so its API can be designed independently.