fix: show validation error when null is bound to primitive bean property#24266
Merged
mcollovati merged 3 commits intovaadin:mainfrom May 6, 2026
Merged
Conversation
When a field bound to a primitive property (e.g. double) produces a null value through converters, the Binder now returns a descriptive validation error instead of throwing a NullPointerException. Fixes vaadin#24253
|
|
mcollovati
added
the
Contribution
mcollovati
requested changes
May 6, 2026
- Clarify that asRequired must be placed before any converter - Simplify test to use StringToDoubleConverter directly
mcollovati
previously approved these changes
May 6, 2026
Collaborator
mcollovati
left a comment
mcollovati
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the contribution!
adraarda23
force-pushed
the
fix/binder-primitive-null-validation
branch
from
866c4c1 to
2f33262
Compare
mcollovati
approved these changes
May 6, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a field bound to a primitive property (e.g. double) produces a null value through converters, the Binder now returns a descriptive validation error instead of throwing a NullPointerException.
Fixes #24253
Description
When a
Binderfield is bound to a primitive bean property (e.g.double) viabind("propertyName"), and the field value becomesnullthrougha converter chain (for example
StringToBigDecimalConverter→BigDecimalToDoubleConverterproducingnull), the Binder was throwing aNullPointerExceptioninstead of showing a user-facing validation error.This fix detects primitive-typed properties in
bind(String propertyName)and adds a converter that returns a descriptiveResult.error(...)when the value is
null, preventing the NPE and surfacing a meaningful message.Fixes #24253
Type of change
Checklist