test: set login form values via DOM property in security ITs#24359
Merged
Conversation
`sendKeys` on the plain `<input>` fields introduced by the flow-components rework intermittently failed to populate the value on the second login in a test (after a prior login + logout), causing the form to POST empty credentials and Spring to 302 back to `/my/login/page?error`. Setting `value` directly via the DOM property bypasses the keystroke/focus/autofill path; the form still submits the new value since the browser reads the DOM property at submit time.
|
caalador
approved these changes
May 18, 2026
Contributor
caalador
left a comment
caalador
left a comment
There was a problem hiding this comment.
On the fence on this one mostly due to the fact that we are testing user input which send keys did, but this one doesn't. Then again there are other tests for setting input so this is ok as it lessens flakiness in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendKeyson the plain<input>fields introduced by the flow-components rework intermittently failed to populate the value on the second login in a test (after a prior login + logout), causing the form to POST empty credentials and Spring to 302 back to/my/login/page?error. Settingvaluedirectly via the DOM property bypasses the keystroke/focus/autofill path; the form still submits the new value since the browser reads the DOM property at submit time.