Skip to content

feat: add RouterState.isNavigationPending()#24771

Merged
Artur- merged 2 commits into
mainfrom
fix/24471-2026-06-12-1291-feat-routerstate-isnavigationpending
Jun 23, 2026
Merged

feat: add RouterState.isNavigationPending()#24771
Artur- merged 2 commits into
mainfrom
fix/24471-2026-06-12-1291-feat-routerstate-isnavigationpending

Conversation

@tltv

@tltv tltv commented Jun 23, 2026

Copy link
Copy Markdown
Member

Add RouterState.isNavigationPending() to detect pre-navigation state, so user code can detect the pre-navigation state without an NPE.

Fixes #24471

@tltv tltv marked this pull request as ready for review June 23, 2026 08:12
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Test Results

 1 453 files  ±0   1 453 suites  ±0   1h 24m 39s ⏱️ - 2m 24s
10 269 tests +2  10 201 ✅ +2  68 💤 ±0  0 ❌ ±0 
10 741 runs  +2  10 672 ✅ +2  69 💤 ±0  0 ❌ ±0 

Results for commit 3666ec6. ± Comparison against base commit ca08d44.

@Artur- Artur- added this pull request to the merge queue Jun 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
@Artur- Artur- added this pull request to the merge queue Jun 23, 2026
Merged via the queue into main with commit 8463bd0 Jun 23, 2026
34 checks passed
@Artur- Artur- deleted the fix/24471-2026-06-12-1291-feat-routerstate-isnavigationpending branch June 23, 2026 09:01
vaadin-bot added a commit that referenced this pull request Jun 23, 2026
This PR cherry-picks changes from the original PR #24771 to branch 25.2.
---
#### Original PR description
> Add RouterState.isNavigationPending() to detect pre-navigation state,
so user code can detect the pre-navigation state without an NPE.
> 
> Fixes #24471

Co-authored-by: Tomi Virtanen <tltv@vaadin.com>
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI routerState's navigationTarget leads to NPE in browserless tests

4 participants