Skip to content

Commit ff14786

Browse files
fix: use correct selector for crud dialog overlay in Aura (#12261) (#12265)
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
1 parent 57810b3 commit ff14786

15 files changed

Lines changed: 25 additions & 3 deletions

packages/aura/src/components/overlay.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
vaadin-combo-box,
3232
vaadin-confirm-dialog,
3333
vaadin-context-menu,
34-
vaadin-crud-dialog,
34+
vaadin-crud,
3535
vaadin-date-picker,
3636
vaadin-dialog,
3737
vaadin-login-overlay,

packages/aura/src/surface.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ vaadin-upload-file,
3939
vaadin-combo-box,
4040
vaadin-confirm-dialog,
4141
vaadin-context-menu,
42-
vaadin-crud-dialog,
42+
vaadin-crud,
4343
vaadin-date-picker,
4444
vaadin-dialog,
4545
vaadin-login-overlay,

packages/crud/test/visual/aura/crud.test.js

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { fixtureSync, nextRender } from '@vaadin/testing-helpers';
22
import { visualDiff } from '@web/test-runner-visual-regression';
33
import '@vaadin/aura/aura.css';
4+
import '../../not-animated-styles.css';
45
import '../../../vaadin-crud.js';
56

67
describe('crud', () => {
@@ -9,7 +10,7 @@ describe('crud', () => {
910
beforeEach(async () => {
1011
div = document.createElement('div');
1112
div.style.height = '100%';
12-
element = fixtureSync('<vaadin-crud></vaadin-crud>', div);
13+
element = fixtureSync('<vaadin-crud style="height: 100%"></vaadin-crud>', div);
1314
element.items = [{ name: { first: 'John', last: 'Doe' } }, { name: { first: 'Jane', last: 'Doe' } }];
1415
await nextRender();
1516
});
@@ -27,4 +28,25 @@ describe('crud', () => {
2728
element.setAttribute('theme', 'no-row-borders');
2829
await visualDiff(element, 'no-row-borders');
2930
});
31+
32+
['default', 'aside', 'bottom'].forEach((position) => {
33+
describe(`editor-position-${position}`, () => {
34+
beforeEach(async () => {
35+
switch (position) {
36+
case 'aside':
37+
case 'bottom':
38+
element.editorPosition = position;
39+
await nextRender();
40+
break;
41+
default:
42+
// Do nothing
43+
}
44+
});
45+
46+
it(`editor-position-${position}`, async () => {
47+
element.editedItem = {};
48+
await visualDiff(div, `editor-position-${position}`);
49+
});
50+
});
51+
});
3052
});
-31.3 KB
Loading
5.09 KB
Loading
42.1 KB
Loading
33.4 KB
Loading
32.3 KB
Loading
5.05 KB
Loading
-35.7 KB
Loading

0 commit comments

Comments
 (0)