Skip to content

fix: use correct selector for crud dialog overlay in Aura - #12261

Merged
web-padawan merged 3 commits into
mainfrom
fix/aura-crud-dialog
Jul 29, 2026
Merged

fix: use correct selector for crud dialog overlay in Aura#12261
web-padawan merged 3 commits into
mainfrom
fix/aura-crud-dialog

Conversation

@web-padawan

@web-padawan web-padawan commented Jul 29, 2026

Copy link
Copy Markdown
Member

Description

Fixed incorrect usage of vaadin-crud-dialog - that element is in shadow DOM.
Instead, vaadin-crud::part(overlay) is a correct way to target dialog's overlay.

Also added missing Aura visual test for crud editor (default, aside, bottom).

Type of change

  • Bugfix

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

@web-padawan
web-padawan requested a review from jouni July 29, 2026 06:16
Comment thread packages/crud/test/visual/aura/crud.test.js Outdated
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan requested a review from vursen July 29, 2026 06:35
@web-padawan
web-padawan removed the request for review from jouni July 29, 2026 06:37
@web-padawan
web-padawan merged commit 32c6ad6 into main Jul 29, 2026
13 checks passed
@web-padawan
web-padawan deleted the fix/aura-crud-dialog branch July 29, 2026 06:44
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 25.1, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 32c6ad6
error: could not apply 32c6ad6... fix: use correct selector for crud dialog overlay in Aura (#12261)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan added a commit that referenced this pull request Jul 29, 2026
…12265)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.3.0-alpha8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants