test: activate keyboard mode in popover focus visual tests#11468
Merged
web-padawan merged 1 commit intomainfrom Apr 9, 2026
Merged
test: activate keyboard mode in popover focus visual tests#11468web-padawan merged 1 commit intomainfrom
web-padawan merged 1 commit intomainfrom
Conversation
Focus the target using sendKeys Tab before opening the popover so that keyboard mode is active and the overlay focus-ring is shown. Without this, Playwright 1.59+ (Chrome 145) no longer shows the browser default focus outline for programmatic focus, causing the focus-visible screenshots to lose their focus ring. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
web-padawan
force-pushed
the
fix/popover-focus-visual-test
branch
from
3d88a7c to
a48122c
Compare
|
vursen
approved these changes
Apr 9, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
web-padawan
added a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendKeys({ press: 'Tab' })before opening, so that keyboard mode is active and the overlay:focus-visiblering is shown in screenshots:focus-visibleno longer applies because without keyboard activation,focus({ focusVisible: false })is called. Since the popover overlay receives focus programmatically, the focus ring would disappear from screenshots without this change.Test plan
yarn test:base --group popoverpasses with updated screenshots🤖 Generated with Claude Code