Skip to content

test: activate keyboard mode in popover focus visual tests (#11468) (CP: 25.1)#11470

Merged
web-padawan merged 1 commit into25.1from
cherry-pick-11468-to-25.1-1775737009118
Apr 9, 2026
Merged

test: activate keyboard mode in popover focus visual tests (#11468) (CP: 25.1)#11470
web-padawan merged 1 commit into25.1from
cherry-pick-11468-to-25.1-1775737009118

Conversation

@vaadin-bot
Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #11468 to branch 25.1.


Original PR description

Summary

  • Focus the popover target using sendKeys({ press: 'Tab' }) before opening, so that keyboard mode is active and the overlay :focus-visible ring is shown in screenshots
  • After updating Playwright to 1.59 (Chrome 145+), the :focus-visible no longer applies because without keyboard activation, focus({ focusVisible: false }) is called. Since the popover overlay receives focus programmatically, the focus ring would disappear from screenshots without this change.

Test plan

  • yarn test:base --group popover passes with updated screenshots

🤖 Generated with Claude Code

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2026

@web-padawan web-padawan merged commit 2c07388 into 25.1 Apr 9, 2026
10 checks passed
@web-padawan web-padawan deleted the cherry-pick-11468-to-25.1-1775737009118 branch April 9, 2026 12:21
@vaadin-bot
Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 25.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants