Skip to content

test: improve coverage for tabsheet loading state fallback height#12183

Merged
web-padawan merged 1 commit into
mainfrom
test/tabsheet-test-coverage
Jul 17, 2026
Merged

test: improve coverage for tabsheet loading state fallback height#12183
web-padawan merged 1 commit into
mainfrom
test/tabsheet-test-coverage

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Improved tests for the fallback height: current test was unreliable and didn't use any await.
This resolves following issues revealed when running Stryker mutation testing:

[Survived] StringLiteral
src/vaadin-tabsheet-mixin.js:223:35
-           content.style.minHeight = `${content.offsetHeight}px`;
+           content.style.minHeight = ``;

[Survived] BlockStatement
src/vaadin-tabsheet-mixin.js:221:38
-         } else if (hasOneVisiblePanel) {
-           // Make sure the empty content has a fallback height in loading state..
-           content.style.minHeight = `${content.offsetHeight}px`;
-         }
+         } else if (hasOneVisiblePanel) {}

[Survived] ConditionalExpression
src/vaadin-tabsheet-mixin.js:221:18
-         } else if (hasOneVisiblePanel) {
+         } else if (false) {

Type of change

  • Test

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@web-padawan
web-padawan requested a review from vursen July 17, 2026 13:34
@sonarqubecloud

Copy link
Copy Markdown

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

@web-padawan
web-padawan merged commit 760ac56 into main Jul 17, 2026
14 checks passed
@web-padawan
web-padawan deleted the test/tabsheet-test-coverage branch July 17, 2026 13:50
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.3.0-alpha6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants