Skip to content

fix: suppress pointer-events on overlays slotted content (#12471) (CP: 25.2) - #12478

Merged
web-padawan merged 1 commit into
25.2from
cherry-pick-12471-to-25.2-1787568562584
Aug 24, 2026
Merged

fix: suppress pointer-events on overlays slotted content (#12471) (CP: 25.2)#12478
web-padawan merged 1 commit into
25.2from
cherry-pick-12471-to-25.2-1787568562584

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #12471 to branch 25.2.


Original PR description

Description

Fixes #12465

  • Added suppressed - internal attribute on vaadin-overlay, intentionally undocumented for styling.
  • Changed OverlayStackMixin to set the new attribute rather than modifying inline style directly
  • Adapted CSS block with closing in animation styles to use suppressed, moved it to base styles
  • Updated Lumo overlay.css mixin accordingly - some overlays like dialog are not using base styles
  • Improved IT added in fix: always close select on outside click when in modeless dialog #8727

Type of change

  • Bugfix

How to Test

Update dev/dialog.html - make both dialogs modeless, add snippet below to dialog2.renderer:

const select = document.createElement('vaadin-select');
select.label = 'Select';
select.innerHTML = `
  <vaadin-select-list-box slot="overlay">
    <vaadin-select-item value="1">Option 1</vaadin-select-item>
    <vaadin-select-item value="2">Option 2</vaadin-select-item>
    <vaadin-select-item value="3">Option 3</vaadin-select-item>
  </vaadin-select-list-box>
`;

Steps to verify the fix works:

  1. Open parent dialog, then nested dialog, then its nested select
  2. Click on parent dialog header title or the footer "Action" button
  3. Before: parent dialog is focused. After: only select is closed

@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 0cbaa37 into 25.2 Aug 24, 2026
10 checks passed
@web-padawan
web-padawan deleted the cherry-pick-12471-to-25.2-1787568562584 branch August 24, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants