Skip to content

fix: do not fire change for time-picker value set programmatically (#12470) (CP: 25.2) - #12480

Merged
web-padawan merged 1 commit into
25.2from
cherry-pick-12470-to-25.2-1787571047859
Aug 24, 2026
Merged

fix: do not fire change for time-picker value set programmatically (#12470) (CP: 25.2)#12480
web-padawan merged 1 commit into
25.2from
cherry-pick-12470-to-25.2-1787571047859

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #12470 to branch 25.2.


Original PR description

Description

Extracted from #12467

Depends on #12468

A value finer than the step allows, e.g. 10:00:30 with the default step, was marked as committed before being stripped to 10:00, so the next commit attempt fired change for a value the user never entered.

Type of change

  • Bugfix

How to test

  1. Open dev/time-picker.html
  2. In the browser console, run:
    const timePicker = document.querySelector('vaadin-time-picker');
    timePicker.addEventListener('change', () => console.log('change'));
    timePicker.value = '10:00:30';
  3. The field shows 10:00
  4. Click the field, then click outside it
  5. Nothing is logged

@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 1b6cf4a into 25.2 Aug 24, 2026
10 checks passed
@web-padawan
web-padawan deleted the cherry-pick-12470-to-25.2-1787571047859 branch August 24, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants