Skip to content

chore: update Quill version to 1.3.7 (#11785) (CP: 23.6) - #12616

Merged
web-padawan merged 3 commits into
23.6from
quill-1.3.7-v23
Sep 4, 2026
Merged

chore: update Quill version to 1.3.7 (#11785) (CP: 23.6)#12616
web-padawan merged 3 commits into
23.6from
quill-1.3.7-v23

Conversation

@TatuLund

@TatuLund TatuLund commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

This PR cherry-picks changes from the original PR #11785 to branch 23.6.

The 23.6 branch still carried the old webpack 3 build of Quill 1.3.6, so the one-attribute
patch could not be applied on its own. Instead the whole vendor bundle is replaced with the
same build 24.10 ships, which makes packages/rich-text-editor/vendor/ byte-identical to
24.10 after #11785.

  • Updated vaadin-quill.js to the Quill 1.3.7 based Vaadin fork build, which adds rel="noopener noreferrer" to the <a> elements created by the link format
  • Renamed vaadin-quill.min.js.map to vaadin-quill.js.map so that the sourceMappingURL comment in the new bundle resolves

Type of change

  • Bugfix

How to test

  1. Run yarn start and open any dev page, for example dev/text-field.html
  2. In the browser console, run:
    await import('/packages/rich-text-editor/vaadin-rich-text-editor.js');
    const rte = document.body.appendChild(document.createElement('vaadin-rich-text-editor'));
    rte.value = JSON.stringify([
      { insert: 'vaadin.com', attributes: { link: 'https://vaadin.com' } },
      { insert: '\n' },
    ]);
  3. Run rte.htmlValue — the <a> element should have both rel="noopener noreferrer" and target="_blank"

Description

Updated Quill bundle to include vaadin/quill@fd377c3 adding rel="noopener noreferrer" to <a> elements.

Type of change

  • Bugfix

@TatuLund
TatuLund marked this pull request as ready for review September 4, 2026 12:56
The updated bundle refers to vaadin-quill.js.map, which the previous
webpack build renamed from vaadin-quill.min.js.map in #7613.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

@web-padawan web-padawan changed the title chore: Update Quill to 1.3.7 (V23) chore: update Quill version to 1.3.7 (#11785) (CP: 23.6) Sep 4, 2026

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified that vendor/vaadin-quill.js is identical to the one on 24.10 branch.

@web-padawan
web-padawan merged commit 85c4e75 into 23.6 Sep 4, 2026
10 checks passed
@web-padawan
web-padawan deleted the quill-1.3.7-v23 branch September 4, 2026 13:53
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.6.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants