fix: detail panel star button sync#156
Merged
vakovalskii merged 1 commit intovakovalskii:mainfrom Apr 10, 2026
Merged
Conversation
akolotov
changed the title
apstenku123
added a commit
to apstenku123/codedash
that referenced
this pull request
Apr 11, 2026
apstenku123
added a commit
to apstenku123/codedash
that referenced
this pull request
Apr 11, 2026
- vakovalskii#155 clipboard copy fallback on non-secure origins (execCommand shim) - vakovalskii#156 star button sync in detail panel (already applied earlier) - vakovalskii#159 bind address vs browser URL separation (execFile, safer) - ca70fd2 dual metrics: user_messages (real) + total_interactions (all) - d3f4326 Node >= 18 version check at startup with clear error Skipped: vakovalskii#100 Warp launch config (non-iTerm2), vakovalskii#157 session name refactor (too many touches), vakovalskii#160 badge display config (non-critical), analytics totalSessionsAll (already have similar in createCostAggregator).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-facing issue
When a user opened a session in the detail panel and clicked the star button, the session was starred or unstarred in storage, but the button inside the open detail panel did not immediately update its label or active state. This made the UI look stale and left users unsure whether the action worked until they manually refreshed or closed and reopened the panel.
Root cause
The shared
toggleStar()logic already updated persisted star state and rerendered the session views, but the live frontend no longer refreshed the open detail panel button after the action completed. The older backup implementation had an extra DOM update for the.detail-starelement, and that behavior was missing from the current code path.Fix
I restored the missing detail-panel-specific update in
toggleStar()so that, after the star list is updated and the main views rerender, the open.detail-starbutton is also updated in place.This keeps the detail panel label and active styling aligned with the new star state immediately.
Why this is safe
src/frontend/app.js..detail-starselector that is already present in the detail panel markup.