Closed
Conversation
Owner
|
20k line diff — looks like the entire codebase was reformatted/overwritten. Please submit a focused PR with only the Copilot-specific changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes session deletion consistency and completes Copilot integration stability so deleted sessions do not reappear after refresh.
What changed
Why this functionality is added
Before this fix, delete could appear successful in UI but stale server-side caches could still return old sessions on subsequent loads.
For Copilot, deletion also needed to account for workspace-scoped storage layout and multiple potential roots.
User-facing behavior
Why this does not break anything
Cache invalidation is scoped to runtime caches only and runs after delete operations.
Existing non-Copilot delete behavior is preserved, but now stricter (explicit error if nothing was deleted).
Copilot deletion remains path-safe and only targets files/directories matching the session id.
No migration or format changes are required.
Validation
Manual checks executed locally:
Observed results:
Known limitations
Risk assessment
Low risk.
Changes are localized to deletion consistency and Copilot parsing/filtering paths, with explicit fallbacks and clear error behavior.
Main behavioral tightening is intentional: delete now fails loudly when nothing was deleted, instead of pretending success.