fix: unbalanced div broke Projects launcher card layout - #282
Open
NovakPAai wants to merge 1 commit into
Open
Conversation
The missing-folder-detection refactor added the launcher-card-actions wrapper only for the missing-folder branch, but left the pre-existing closing </div> in the normal (folder-exists) branch without ever opening it. The unbalanced markup made every action button/select render as a direct flex-column child of .launcher-card, stretching each one to full card width on its own row instead of a compact action row. Also brings the <select> terminal-panes control in line with the button sizing in that row, and pushes the rarely-used Remove control to the end of the row with quieter styling so it doesn't compete visually with New/Last.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.launcher-card-actionswrapper only in the missing-folder branch, but left the pre-existing closing</div>in the normal (folder-exists) branch unopened. The unbalanced markup made every action button/select render as a direct flex-column child of.launcher-card, stretching each one to full card width on its own row instead of a compact action row — this is the "криво выставлены блоки" layout the user reported (see screenshot in conversation, v7.16.0).<div class="launcher-card-actions">before the button row for existing-folder cards.<select>terminal-panes control so it matches button sizing instead of falling back to the smaller default.×) control to the end of the row (margin-left: auto) with quieter, muted styling (turns red only on hover) so it doesn't visually compete with New/Last/Terminal.Test plan
node --test "test/**/*.test.js"— 257 passed, 1 skipped (win32-only)node bin/cli.js run), verified the Projects launcher grid at 1440px and 1024px viewports via Playwright — cards render as a proper multi-column grid with New/Last/Terminal on one row and Remove aligned right; missing-folder cards keep their dashed red border + Re-clone/Remove row🤖 Generated with Claude Code