mapdata: scope pipe bottlenecks to the line, not the whole network - #10
Merged
Conversation
A Mk2 trunk feeding two Mk1 branches through a junction warned about a bottleneck: the detector ranked every rated member of the FGPipeNetwork, which spans junctions. Belts never had this problem because the game's conveyor chain actors end at splitters/mergers (verified: at every splitter, even 1-in/1-out ones). Pipes now walk mConnectedComponent links outward from the hovered segment instead: through rated pipes/pumps and through junctions acting as plain couplings (<= 2 connected ports), stopping at junctions that actually split or merge flow (>= 3 connected ports) and at anything unrated (machines, valves, tanks). Scope string becomes "line" (the tooltip already words non-network scopes that way). Verified on the report's save (3-port junction rig: no warning on any side) and solo_autosave_1 (5,855 rated segments: only the 4 genuine in-line Mk1-pump-in-Mk2-run mixes still warn; 2-port pass-through junctions keep the line going). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
satisfactorymap | 658e57b | Jul 25 2026, 04:34 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a false bottleneck warning: a Mk2 pipe (600/min) feeding two Mk1 pipes (300/min) through a junction warned that the Mk1s slow the "network" down. The detector ranked every member of the FGPipeNetwork, which spans junctions -- belts never had this problem because the game's conveyor chain actors end at splitters/mergers.
Pipe bottlenecks are now scoped to the hovered segment's line: the walk follows mConnectedComponent links through rated pipes/pumps and through junctions acting as plain couplings (<=2 connected ports), and stops at junctions that actually split/merge flow (>=3 connected ports) and at anything unrated (machines, valves, tanks).
Also checked per the report: belt chains end at every splitter, even 1-in/1-out ones (437 checked) -- that's the game's own chain model, so belts are untouched.
Test plan
🤖 Generated with Claude Code