Add global.catalogSource fallback for OLM subscriptions - #137
Merged
mbaldessari merged 2 commits intoAug 7, 2026
Merged
Conversation
Problem: The clustergroup chart hardcodes OLM subscription source fallback per-entry with no global hook. Disconnected deployments must override source on every subscription (8+ operators = significant repetition). Solution: Add global.catalogSource and global.catalogSourceNamespace fields that provide a middle layer in the fallback chain, following the precedent of global.options.installPlanApproval and useCSV. Fallback order (highest to lowest precedence): 1. Per-subscription source (allows specific operators to use different catalogs) 2. global.catalogSource (new - allows one-value airgap repoint) 3. Hardcoded default 'redhat-operators' (unchanged) Changes: - templates/core/subscriptions.yaml: Update both Subscription blocks to use nested defaults: default (default 'redhat-operators' global) per-sub - values.schema.json: Add catalogSource and catalogSourceNamespace fields under Global definition Backward Compatibility: Fully backward compatible - when global.catalogSource is unset, behavior is identical to current. Per-subscription source still takes precedence. Use Case: Airgap/disconnected deployments can now set one global.catalogSource value instead of overriding every subscription individually.
Contributor
Author
|
@mbaldessari - Related to 'how do we make disconnect easier' |
Contributor
|
Thanks! |
Contributor
|
fwiw clustergroup chart 0.9.58 with this change has just been released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the clustergroup chart hardcodes the OLM subscription source fallback per-entry with no global hook:
This means every disconnected/airgap consumer must override
source:on every single subscription. For patterns with 8+ operators, this creates significant repetition and increases the risk of missing an operator during mirror setup.Solution
Add
global.catalogSourceandglobal.catalogSourceNamespacefields that act as a middle layer in the fallback chain, following the precedent already established byglobal.options.installPlanApprovalandglobal.options.useCSV.Fallback order (highest to lowest precedence):
source(allows specific operators to use different catalogs)global.catalogSource(new - allows one-value airgap repoint)"redhat-operators"(unchanged)Changes
templates/core/subscriptions.yaml:
values.schema.json - Add under
Globaldefinition:Backward Compatibility
✅ Fully backward compatible - existing patterns are unaffected:
global.catalogSourceis unset, behavior is identical to todaysourcestill takes precedence (certified operators can use different catalogs)"redhat-operators"when neither global nor per-sub values are setUse Case
Airgap/disconnected deployments where all operators come from a single mirrored catalog:
Precedent
This follows the existing pattern used by
global.options.installPlanApprovalandglobal.options.useCSV, which already provide global defaults for subscription fields.Testing Checklist