Skip to content

Removal of Keycloak setup content#164

Merged
mlorenzofr merged 1 commit into
validatedpatterns:mainfrom
sabre1041:cleanup-keycloak-setup
Jul 22, 2026
Merged

Removal of Keycloak setup content#164
mlorenzofr merged 1 commit into
validatedpatterns:mainfrom
sabre1041:cleanup-keycloak-setup

Conversation

@sabre1041

Copy link
Copy Markdown
Collaborator

Automates the removal of additional secrets that are used to seed Keycloak

  • acs-oidc-client-secret
  • rhtpa-oidc-cli-secret
  • qtodo-client-id

Renamed cleanup resources cleanup-keycloak-users -> cleanup-keycloak-setup

@sabre1041
sabre1041 requested a review from mlorenzofr July 21, 2026 23:57

@mlorenzofr mlorenzofr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine, and the logic seems clear to me

My only suggestion is that, since we're renaming cleanup-keycloak-users to cleanup-keycloak-setup, we should also rename the cleanup-keycloak-users.yaml file. It's not a big deal, helm works the same. It's just to keep the naming consistent.

Signed-off-by: Andrew Block <andy.block@gmail.com>
@sabre1041
sabre1041 force-pushed the cleanup-keycloak-setup branch from 1c053fb to 05549d9 Compare July 22, 2026 13:19
@sabre1041

Copy link
Copy Markdown
Collaborator Author

It works fine, and the logic seems clear to me

My only suggestion is that, since we're renaming cleanup-keycloak-users to cleanup-keycloak-setup, we should also rename the cleanup-keycloak-users.yaml file. It's not a big deal, helm works the same. It's just to keep the naming consistent.

no worries. Made the relevant change

@mlorenzofr mlorenzofr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mlorenzofr
mlorenzofr merged commit 8867e72 into validatedpatterns:main Jul 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants