Skip to content

Hunner/release 2.13.8#546

Merged
hunner merged 2 commits into
mainfrom
hunner/release-2.13.8
Jul 23, 2026
Merged

Hunner/release 2.13.8#546
hunner merged 2 commits into
mainfrom
hunner/release-2.13.8

Conversation

@hunner

@hunner hunner commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Pull Request Description

What and why?

Releasing v2.13.8

Includes

Release notes

None; just a release bump pr

Checklist

  • What and why
  • Screenshots or videos (Frontend)
  • How to test
  • What needs special review
  • Dependencies, breaking changes, and deployment notes
  • Labels applied
  • PR linked to Shortcut
  • Unit tests added (Backend)
  • Tested locally
  • Documentation updated (if required)
  • Environment variable additions/changes documented (if required)

hunner and others added 2 commits July 23, 2026 10:11
BSD sed (macOS) requires 'sed -i ""' while GNU sed (Linux) rejects it;
write to a temp file and mv into place so the target works on both.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@hunner
hunner requested a review from juanmleng July 23, 2026 17:14
@hunner hunner added internal Not to be externalized in the release notes support Support-related PR labels Jul 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Summary

This PR primarily focuses on updating the software version from 2.13.7 to 2.13.8 across multiple project files including pyproject.toml, DESCRIPTION (located in r/validmind), the package's version.py, and the uv.lock file. Additionally, the Makefile has been updated to handle the DESCRIPTION file update in a more portable manner by using a temporary file rather than modifying the file in place. These changes ensure that the version information is kept consistent across the project and that the Makefile command is compatible with different sed implementations.

The changes are functional in that they maintain version consistency and improve the robustness of the version update process. No behavioral changes are introduced apart from the updated version and improved Makefile handling.

Test Suggestions

  • Verify that after running the version update command via Makefile, the version in version.py, DESCRIPTION, and pyproject.toml is correctly updated to 2.13.8.
  • Test the Makefile command on different operating systems to ensure the sed command works as expected without in-place file editing issues.
  • Check that the commit message or version bump output is correct and consistent across all files.
  • Run the project's automated tests to ensure that no regressions were introduced with these changes.

@hunner
hunner requested a review from jamadriz July 23, 2026 17:37
@juanmleng

Copy link
Copy Markdown
Contributor

Nice catch on the Makefile fix. Switching sed -i '' (which only works on BSD/macOS sed) to the sed '...' > .tmp && mv form means make version will now work in Linux CI rather than only on a Mac, and the && keeps the original file intact if sed ever fails.

One tiny thing, take it or leave it: if sed does fail, the DESCRIPTION.tmp gets left behind. Since the target does an explicit-file git add, it won't actually get committed, so this is really just tidiness — a || rm -f r/validmind/DESCRIPTION.tmp would clean it up if you want it airtight.

LGTM 👍

@hunner
hunner merged commit b1071e3 into main Jul 23, 2026
23 checks passed
@hunner
hunner deleted the hunner/release-2.13.8 branch July 23, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes support Support-related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants